Home assignment #4

[cpptester]

Tested revision 714 by pestov.andrej.

Main tests

test	stage	result	info	log
​comp_char_traits_custom.cpp	gcc62	FAILURE		​comp_char_traits_custom-gcc62.log
​comp_plus_c_str_returns_non_const.cpp	gcc62	FAILURE		​comp_plus_c_str_returns_non_const-gcc62.log
​comp_plus_char_returns_non_const.cpp	gcc62	FAILURE		​comp_plus_char_returns_non_const-gcc62.log
​comp_plus_lazy_string_returns_non_const.cpp	gcc62	FAILURE		​comp_plus_lazy_string_returns_non_const-gcc62.log
​ncomp_c_str_const.cpp	gcc62	FAILURE
​run_char_traits_custom.cpp	gcc62	FAILURE		​run_char_traits_custom-gcc62.log
​run_clear_no_mem.cpp	gcc62	SUCCESS
	run	FAILURE	exit code 139	​run_clear_no_mem-run.log
​run_lazy_istring_less.cpp	gcc62	SUCCESS
	run	FAILURE	exit code 139	​run_lazy_istring_less-run.log
​run_lazy_istring_less_rev.cpp	gcc62	SUCCESS
	run	FAILURE	exit code 139	​run_lazy_istring_less_rev-run.log
​run_less.cpp	gcc62	SUCCESS
	run	FAILURE	exit code 139	​run_less-run.log

Common header used in some tests: ​common.h

[cpptester]

Tested revision 726 by pestov.andrej.

Smoke tests

test	stage	result	info	log
​run_smoke_test.cpp	gcc62	FAILURE		​run_smoke_test-gcc62.log

Common header used in some tests: ​common.h

[cpptester]

Tested revision 727 by pestov.andrej.

Smoke tests

test	stage	result	info	log
​run_smoke_test.cpp	gcc62	SUCCESS
	run	SUCCESS
	valgrind	FAILURE	exit code 1	​run_smoke_test-valgrind.log
	gcc62-asan	SUCCESS
	asan	FAILURE	exit code 1	​run_smoke_test-asan.log
	clang-san	SUCCESS
	san	FAILURE	exit code 1	​run_smoke_test-san.log

Common header used in some tests: ​common.h

[cpptester]

Tested revision 730 by pestov.andrej.

Main tests

test	stage	result	info	log
​ncomp_c_str_const.cpp	gcc62	FAILURE
​run_aug_plus.cpp	gcc62	SUCCESS
	run	SUCCESS
	valgrind	FAILURE	exit code 1	​run_aug_plus-valgrind.log
	gcc62-asan	SUCCESS
	asan	FAILURE	exit code 1	​run_aug_plus-asan.log
	clang-san	SUCCESS
	san	FAILURE	exit code 1	​run_aug_plus-san.log
​run_aug_plus_aug_plus.cpp	gcc62	SUCCESS
	run	SUCCESS
	valgrind	FAILURE	exit code 1	​run_aug_plus_aug_plus-valgrind.log
	gcc62-asan	SUCCESS
	asan	FAILURE	exit code 1	​run_aug_plus_aug_plus-asan.log
	clang-san	SUCCESS
	san	FAILURE	exit code 1	​run_aug_plus_aug_plus-san.log
​run_aug_plus_c_str_char_traits_no_mem.cpp	gcc62	SUCCESS
	run	SUCCESS
	valgrind	FAILURE	exit code 1	​run_aug_plus_c_str_char_traits_no_mem-valgrind.log
	gcc62-asan	SUCCESS
	asan	FAILURE	exit code 1	​run_aug_plus_c_str_char_traits_no_mem-asan.log
	clang-san	SUCCESS
	san	FAILURE	exit code 1	​run_aug_plus_c_str_char_traits_no_mem-san.log
​run_aug_plus_c_str_no_mem.cpp	gcc62	SUCCESS
	run	SUCCESS
	valgrind	FAILURE	exit code 1	​run_aug_plus_c_str_no_mem-valgrind.log
	gcc62-asan	SUCCESS
	asan	FAILURE	exit code 1	​run_aug_plus_c_str_no_mem-asan.log
	clang-san	SUCCESS
	san	FAILURE	exit code 1	​run_aug_plus_c_str_no_mem-san.log
​run_aug_plus_c_wstr_no_mem.cpp	gcc62	SUCCESS
	run	FAILURE	exit code 139	​run_aug_plus_c_wstr_no_mem-run.log
​run_aug_plus_char_char_traits_no_mem.cpp	gcc62	SUCCESS
	run	SUCCESS
	valgrind	FAILURE	exit code 1	​run_aug_plus_char_char_traits_no_mem-valgrind.log
	gcc62-asan	SUCCESS
	asan	FAILURE	exit code 1	​run_aug_plus_char_char_traits_no_mem-asan.log
	clang-san	SUCCESS
	san	FAILURE	exit code 1	​run_aug_plus_char_char_traits_no_mem-san.log
​run_aug_plus_char_no_mem.cpp	gcc62	SUCCESS
	run	SUCCESS
	valgrind	FAILURE	exit code 1	​run_aug_plus_char_no_mem-valgrind.log
	gcc62-asan	SUCCESS
	asan	FAILURE	exit code 1	​run_aug_plus_char_no_mem-asan.log
	clang-san	SUCCESS
	san	FAILURE	exit code 1	​run_aug_plus_char_no_mem-san.log
​run_aug_plus_lazy_str_char_traits_no_mem.cpp	gcc62	SUCCESS
	run	SUCCESS
	valgrind	FAILURE	exit code 1	​run_aug_plus_lazy_str_char_traits_no_mem-valgrind.log
	gcc62-asan	SUCCESS
	asan	FAILURE	exit code 1	​run_aug_plus_lazy_str_char_traits_no_mem-asan.log
	clang-san	SUCCESS
	san	FAILURE	exit code 1	​run_aug_plus_lazy_str_char_traits_no_mem-san.log
​run_aug_plus_lazy_str_no_mem.cpp	gcc62	SUCCESS
	run	SUCCESS
	valgrind	FAILURE	exit code 1	​run_aug_plus_lazy_str_no_mem-valgrind.log
	gcc62-asan	SUCCESS
	asan	FAILURE	exit code 1	​run_aug_plus_lazy_str_no_mem-asan.log
	clang-san	SUCCESS
	san	FAILURE	exit code 1	​run_aug_plus_lazy_str_no_mem-san.log

Common header used in some tests: ​common.h

[cpptester]

Tested revision 744 by pestov.andrej.

Main tests

test	stage	result	info	log
​ncomp_c_str_const.cpp	gcc62	FAILURE
​run_ctor_no_mem.cpp	gcc62	SUCCESS
	run	FAILURE	exit code 139	​run_ctor_no_mem-run.log
​run_ctor_repeat.cpp	gcc62	SUCCESS
	run	SUCCESS
	valgrind	FAILURE	exit code 1	​run_ctor_repeat-valgrind.log
	gcc62-asan	SUCCESS
	asan	FAILURE	exit code 1	​run_ctor_repeat-asan.log
	clang-san	SUCCESS
	san	FAILURE	exit code 1	​run_ctor_repeat-san.log
​run_ctor_repeat_char_traits_no_mem.cpp	gcc62	SUCCESS
	run	FAILURE	exit code 139	​run_ctor_repeat_char_traits_no_mem-run.log
​run_ctor_repeat_no_mem.cpp	gcc62	SUCCESS
	run	FAILURE	exit code 139	​run_ctor_repeat_no_mem-run.log
​run_empty.cpp	gcc62	SUCCESS
	run	SUCCESS
	valgrind	FAILURE	exit code 1	​run_empty-valgrind.log
	gcc62-asan	SUCCESS
	asan	FAILURE	exit code 1	​run_empty-asan.log
	clang-san	SUCCESS
	san	FAILURE	exit code 1	​run_empty-san.log
​run_empty_eq.cpp	gcc62	SUCCESS
	run	SUCCESS
	valgrind	FAILURE	exit code 1	​run_empty_eq-valgrind.log
	gcc62-asan	SUCCESS
	asan	FAILURE	exit code 1	​run_empty_eq-asan.log
	clang-san	SUCCESS
	san	FAILURE	exit code 1	​run_empty_eq-san.log
​run_empty_wide.cpp	gcc62	SUCCESS
	run	SUCCESS
	valgrind	FAILURE	exit code 1	​run_empty_wide-valgrind.log
	gcc62-asan	SUCCESS
	asan	FAILURE	exit code 1	​run_empty_wide-asan.log
	clang-san	SUCCESS
	san	FAILURE	exit code 1	​run_empty_wide-san.log
​run_index_assign_copy_no_mem.cpp	gcc62	SUCCESS
	run	SUCCESS
	valgrind	FAILURE	exit code 1	​run_index_assign_copy_no_mem-valgrind.log
	gcc62-asan	SUCCESS
	asan	FAILURE	exit code 1	​run_index_assign_copy_no_mem-asan.log
	clang-san	SUCCESS
	san	FAILURE	exit code 1	​run_index_assign_copy_no_mem-san.log
​run_plus.cpp	gcc62	SUCCESS
	run	SUCCESS
	valgrind	FAILURE	exit code 1	​run_plus-valgrind.log
	gcc62-asan	SUCCESS
	asan	FAILURE	exit code 1	​run_plus-asan.log
	clang-san	SUCCESS
	san	FAILURE	exit code 1	​run_plus-san.log

Common header used in some tests: ​common.h

[cpptester]

Tested revision 745 by pestov.andrej.

Main tests

test	stage	result	info	log
​run_plus_c_str_no_mem.cpp	gcc62	SUCCESS
	run	FAILURE	exit code 139	​run_plus_c_str_no_mem-run.log

Common header used in some tests: ​common.h

[cpptester]

Tested revision 746 by pestov.andrej.

All tests passed. Good job!

[cpptester]

Tested revision 746 by pestov.andrej.

Main tests

test	stage	result	info	log
​run_assign_c_str_no_mem.cpp	gcc62	SUCCESS
	run	FAILURE	exit code 139	​run_assign_c_str_no_mem-run.log
​run_char_traits_custom_eq.cpp	gcc62	FAILURE		​run_char_traits_custom_eq-gcc62.log

Common header used in some tests: ​common.h

[cpptester]

Tested revision 906 by pestov.andrej.

Smoke tests

test	stage	result	info	log
​run_smoke_test.cpp	gcc62	SUCCESS
	run	SUCCESS
	valgrind	FAILURE	exit code 1	​run_smoke_test-valgrind.log
	gcc62-asan	SUCCESS
	asan	FAILURE	exit code 1	​run_smoke_test-asan.log
	clang-san	SUCCESS
	san	FAILURE	exit code 1	​run_smoke_test-san.log

Common header used in some tests: ​common.h

[cpptester]

Tested revision 907 by pestov.andrej.

Main tests

test	stage	result	info	log
​run_index_const_wstr.cpp	gcc62	SUCCESS
	run	FAILURE	exit code 139	​run_index_const_wstr-run.log
​run_index_last_const.cpp	gcc62	SUCCESS
	run	FAILURE	exit code 139	​run_index_last_const-run.log

Common header used in some tests: ​common.h

[cpptester]

Tested revision 908 by pestov.andrej.

All tests passed. Good job!

[Vladimir Rutsky]

Замечания:

1. Вместо явного обращения к оператору:

 template <typename T, typename S>
 bool operator==(const T * l, const lazy_basic_string<T, S> & r)
 {
     return (r.operator == (l));
 }

лучше используйте более интуитивное обычное сравнение:

 template <typename T, typename S>
 bool operator==(const T * l, const lazy_basic_string<T, S> & r)
 {
     return r == l;
 }

2. Группу операторов сложения было бы проще реализовать через один operator+= и конструкторы от символа, Си-строки. Например:

lazy_basic_string operator+(const CharT * s2) const
{
  lazy_basic_string temp(*this);
  temp += lazy_basic_string(s2);
  return temp;
}

это должно существенно сократить и упростить код.

3. Используйте в качестве типов для объектов-исключений либо готовые классы-исключения из STL (например, std::runtime_error) или создавайте свои производные классы от std::exception (или других, вроде std::runtime_error):

throw std::string("Bad index");

Исправьте, пожалуйста, в ближайшее время.

[cpptester]

Tested revision 1037 by pestov.andrej.

Main tests

test	stage	result	info	log
​run_aug_plus_c_str_char_traits_no_mem.cpp	gcc62	SUCCESS
	run	FAILURE	exit code 139	​run_aug_plus_c_str_char_traits_no_mem-run.log
​run_aug_plus_c_str_no_mem.cpp	gcc62	SUCCESS
	run	FAILURE	exit code 139	​run_aug_plus_c_str_no_mem-run.log
​run_aug_plus_wchar_no_mem.cpp	gcc62	SUCCESS
	run	FAILURE	exit code 139	​run_aug_plus_wchar_no_mem-run.log
​run_plus_c_str_no_mem.cpp	gcc62	SUCCESS
	run	FAILURE	exit code 139	​run_plus_c_str_no_mem-run.log
​run_plus_char_no_mem.cpp	gcc62	SUCCESS
	run	FAILURE	exit code 139	​run_plus_char_no_mem-run.log
​run_plus_lazy_str_no_mem.cpp	gcc62	SUCCESS
	run	FAILURE	exit code 139	​run_plus_lazy_str_no_mem-run.log

Common header used in some tests: ​common.h

[cpptester]

Tested revision 1046 by pestov.andrej.

All tests passed. Good job!

[cpptester]

Tested revision 1048 by pestov.andrej.

Main tests

test	stage	result	info	log
​run_plus_c_str_no_mem.cpp	gcc62	SUCCESS
	run	FAILURE	exit code 139	​run_plus_c_str_no_mem-run.log
​run_plus_char_no_mem.cpp	gcc62	SUCCESS
	run	FAILURE	exit code 139	​run_plus_char_no_mem-run.log
​run_plus_lazy_str_no_mem.cpp	gcc62	SUCCESS
	run	FAILURE	exit code 139	​run_plus_lazy_str_no_mem-run.log

Common header used in some tests: ​common.h

[cpptester]

Tested revision 1049 by pestov.andrej.

All tests passed. Good job!

[Vladimir Rutsky]

Смените тип тикета на "ожидается проверка", когда ваше решение будет готово для проверки.

[Vladimir Rutsky]

Решение зачтено.

[Vladimir Rutsky]

Milestone ha4-deadline deleted