Проверка ДЗ №3

[cpptester]

Tested revision 327 by tankov.vladislav.

Smoke tests

test	stage	result	info	log
​run_linked_ptr_gen_smoke_test.cpp	gcc62	SUCCESS
	run	SUCCESS
	valgrind	SUCCESS		​run_linked_ptr_gen_smoke_test-valgrind.log
	gcc62-asan	SUCCESS
	asan	SUCCESS
	clang-san	WARNING		​run_linked_ptr_gen_smoke_test-clang-san.log
	san	SUCCESS
​run_smoke_test.cpp	gcc62	SUCCESS
	run	SUCCESS
	valgrind	FAILURE	exit code 1	​run_smoke_test-valgrind.log
	gcc62-asan	SUCCESS
	asan	FAILURE	exit code 1	​run_smoke_test-asan.log
	clang-san	WARNING		​run_smoke_test-clang-san.log
	san	FAILURE	exit code 1	​run_smoke_test-san.log

Common header used in some tests: ​common.h

[cpptester]

Tested revision 328 by tankov.vladislav.

Smoke tests

test	stage	result	info	log
​run_linked_ptr_gen_smoke_test.cpp	gcc62	SUCCESS
	run	SUCCESS
	valgrind	SUCCESS		​run_linked_ptr_gen_smoke_test-valgrind.log
	gcc62-asan	SUCCESS
	asan	SUCCESS
	clang-san	WARNING		​run_linked_ptr_gen_smoke_test-clang-san.log
	san	SUCCESS
​run_smoke_test.cpp	gcc62	SUCCESS
	run	SUCCESS
	valgrind	SUCCESS		​run_smoke_test-valgrind.log
	gcc62-asan	SUCCESS
	asan	SUCCESS
	clang-san	WARNING		​run_smoke_test-clang-san.log
	san	SUCCESS

Common header used in some tests: ​common.h

[cpptester]

Tested revision 339 by tankov.vladislav.

Smoke tests

test	stage	result	info	log
​run_linked_ptr_gen_smoke_test.cpp	gcc62	WARNING		​run_linked_ptr_gen_smoke_test-gcc62.log
	run	SUCCESS
	valgrind	SUCCESS		​run_linked_ptr_gen_smoke_test-valgrind.log
	gcc62-asan	WARNING		​run_linked_ptr_gen_smoke_test-gcc62-asan.log
	asan	SUCCESS
	clang-san	WARNING		​run_linked_ptr_gen_smoke_test-clang-san.log
	san	SUCCESS
​run_smoke_test.cpp	gcc62	WARNING		​run_smoke_test-gcc62.log
	run	SUCCESS
	valgrind	SUCCESS		​run_smoke_test-valgrind.log
	gcc62-asan	WARNING		​run_smoke_test-gcc62-asan.log
	asan	SUCCESS
	clang-san	WARNING		​run_smoke_test-clang-san.log
	san	SUCCESS

Common header used in some tests: ​common.h

[cpptester]

Tested revision 342 by tankov.vladislav.

Main tests

test	stage	result	info	log
​comp_all_sufficient.cpp	gcc62	FAILURE		​comp_all_sufficient-gcc62.log
​comp_assign.cpp	gcc62	FAILURE		​comp_assign-gcc62.log
​comp_assign_const.cpp	gcc62	FAILURE		​comp_assign_const-gcc62.log
​comp_assign_derived.cpp	gcc62	FAILURE		​comp_assign_derived-gcc62.log
​comp_assign_derived_const.cpp	gcc62	FAILURE		​comp_assign_derived_const-gcc62.log
​comp_assign_result.cpp	gcc62	FAILURE		​comp_assign_result-gcc62.log
​comp_assign_result_const.cpp	gcc62	FAILURE		​comp_assign_result_const-gcc62.log
​comp_bool1.cpp	gcc62	FAILURE		​comp_bool1-gcc62.log
​comp_bool2.cpp	gcc62	FAILURE		​comp_bool2-gcc62.log
​comp_bool_const1.cpp	gcc62	FAILURE		​comp_bool_const1-gcc62.log

Common header used in some tests: ​common.h

[cpptester]

Tested revision 344 by tankov.vladislav.

Main tests

test	stage	result	info	log
​comp_all_sufficient.cpp	gcc62	FAILURE		​comp_all_sufficient-gcc62.log
​comp_assign.cpp	gcc62	FAILURE		​comp_assign-gcc62.log
​comp_assign_const.cpp	gcc62	FAILURE		​comp_assign_const-gcc62.log
​comp_assign_derived.cpp	gcc62	FAILURE		​comp_assign_derived-gcc62.log
​comp_assign_derived_const.cpp	gcc62	FAILURE		​comp_assign_derived_const-gcc62.log
​comp_assign_result.cpp	gcc62	FAILURE		​comp_assign_result-gcc62.log
​comp_assign_result_const.cpp	gcc62	FAILURE		​comp_assign_result_const-gcc62.log
​comp_bool1.cpp	gcc62	FAILURE		​comp_bool1-gcc62.log
​comp_bool2.cpp	gcc62	FAILURE		​comp_bool2-gcc62.log
​comp_bool_const1.cpp	gcc62	FAILURE		​comp_bool_const1-gcc62.log

Common header used in some tests: ​common.h

[cpptester]

Tested revision 345 by tankov.vladislav.

Main tests

test	stage	result	info	log
​comp_assign_derived.cpp	gcc62	FAILURE		​comp_assign_derived-gcc62.log
​comp_assign_derived_const.cpp	gcc62	FAILURE		​comp_assign_derived_const-gcc62.log
​ncomp_include_iostream.cpp	gcc62	FAILURE
​run_assign_self_derived_nempty.cpp	gcc62	FAILURE		​run_assign_self_derived_nempty-gcc62.log
​run_gen_015_5x6_062x131_193x285_1x4_1x6_1x6_3x3_0_D034969E.cpp	gcc62	FAILURE		​run_gen_015_5x6_062x131_193x285_1x4_1x6_1x6_3x3_0_D034969E-gcc62.log
​run_gen_021_8x9_4113x4861_397x815_4x4_3x4_5x5_4x4_C4F2B4F7.cpp	gcc62	FAILURE		​run_gen_021_8x9_4113x4861_397x815_4x4_3x4_5x5_4x4_C4F2B4F7-gcc62.log
​run_gen_055_15x26_28180541x35357669_1448194617849_DF45FC8F.cpp	gcc62	FAILURE		​run_gen_055_15x26_28180541x35357669_1448194617849_DF45FC8F-gcc62.log

Common header used in some tests: ​common.h

[cpptester]

Tested revision 347 by tankov.vladislav.

Main tests

test	stage	result	info	log
​ncomp_include_iostream.cpp	gcc62	FAILURE

Common header used in some tests: ​common.h

[cpptester]

Tested revision 348 by tankov.vladislav.

All tests passed. Good job!

[Vladimir Rutsky]

Замечания:

1. Используйте static_assert вместо assert в проверке полноты типа. В обоих случаях проверка выполняется на этапе компиляции, но assert с включенным NDEBUG будет скомпилирован в void, т.е. проверка не будет выполнена в типичной "релизной" сборке.

2. Не используйте виртуальные методы. В данном случае базовый класс это приватная деталь реализации, и никто не должен хранить linked_ptr по указателю на базовый класс, и виртуальный деструктор здесь не нужен.

Исправьте, пожалуйста, в ближайшие 60 часов.

[cpptester]

Tested revision 500 by tankov.vladislav.

All tests passed. Good job!

[Vladimir Rutsky]

Решение зачтено. Бонусное задание не выполнено.