Home Assignment #3 (Chernyaev)

[cpptester]

Tested revision 423 by chernyaev.arsenij.

Smoke tests

test	stage	result	info	log
​run_linked_ptr_gen_smoke_test.cpp		SUCCESS
		FAILURE	exit code 139	​run_linked_ptr_gen_smoke_test-run.log
​run_smoke_test.cpp		SUCCESS
		FAILURE	exit code 139	​run_smoke_test-run.log

Common header used in some tests: ​common.h

[Vladimir Rutsky]

Арсений, исправьте, пожалуйста, ваше решение, чтобы оно проходило автотесты.

[Vladimir Rutsky]

Арсений, вы будете исправлять ваше решение?

[cpptester]

Tested revision 573 by chernyaev.arsenij.

Main tests

test	stage	result	info	log
​comp_all_sufficient.cpp		FAILURE		​comp_all_sufficient-gcc62.log
​comp_assign.cpp		FAILURE		​comp_assign-gcc62.log
​comp_assign_const.cpp		FAILURE		​comp_assign_const-gcc62.log
​comp_assign_derived.cpp		FAILURE		​comp_assign_derived-gcc62.log
​comp_assign_derived_const.cpp		FAILURE		​comp_assign_derived_const-gcc62.log
​comp_assign_result.cpp		FAILURE		​comp_assign_result-gcc62.log
​comp_assign_result_const.cpp		FAILURE		​comp_assign_result_const-gcc62.log
​comp_bool1.cpp		FAILURE		​comp_bool1-gcc62.log
​comp_bool2.cpp		FAILURE		​comp_bool2-gcc62.log
​comp_bool_const1.cpp		FAILURE		​comp_bool_const1-gcc62.log

Common header used in some tests: ​common.h

[cpptester]

Tested revision 574 by chernyaev.arsenij.

Main tests

test	stage	result	info	log
​comp_cmp_less.cpp		FAILURE		​comp_cmp_less-gcc62.log
​comp_cmp_less_const1.cpp		FAILURE		​comp_cmp_less_const1-gcc62.log
​comp_cmp_less_const2.cpp		FAILURE		​comp_cmp_less_const2-gcc62.log
​comp_cmp_less_const3.cpp		FAILURE		​comp_cmp_less_const3-gcc62.log
​comp_cmp_less_const4.cpp		FAILURE		​comp_cmp_less_const4-gcc62.log
​comp_cmp_less_const5.cpp		FAILURE		​comp_cmp_less_const5-gcc62.log
​comp_cmp_less_const6.cpp		FAILURE		​comp_cmp_less_const6-gcc62.log
​comp_cmp_less_diff_types1.cpp		FAILURE		​comp_cmp_less_diff_types1-gcc62.log
​comp_cmp_less_diff_types2.cpp		FAILURE		​comp_cmp_less_diff_types2-gcc62.log
​comp_cmp_less_diff_types_const1.cpp		FAILURE		​comp_cmp_less_diff_types_const1-gcc62.log

Common header used in some tests: ​common.h

[cpptester]

Tested revision 575 by chernyaev.arsenij.

Main tests

test	stage	result	info	log
​comp_include_guard.cpp		FAILURE		​comp_include_guard-gcc62.log
​ncomp_incomplete_type1.cpp		FAILURE
​ncomp_incomplete_type2.cpp		FAILURE
​run_gen_030_06x14_229x428_01476078x30421754_4x4_3_54CD291D.cpp		SUCCESS
		FAILURE	exit code 139	​run_gen_030_06x14_229x428_01476078x30421754_4x4_3_54CD291D-run.log
​run_no_ctor_called.cpp		FAILURE		​run_no_ctor_called-gcc62.log
​run_op1.cpp		FAILURE		​run_op1-gcc62.log
​run_single_object.cpp		FAILURE		​run_single_object-gcc62.log
​run_single_object2.cpp		FAILURE		​run_single_object2-gcc62.log
​run_single_object_multiple_ptrs.cpp		FAILURE		​run_single_object_multiple_ptrs-gcc62.log
​run_test.cpp		FAILURE		​run_test-gcc62.log

Common header used in some tests: ​common.h

[cpptester]

Tested revision 576 by chernyaev.arsenij.

Main tests

test	stage	result	info	log
​ncomp_incomplete_type1.cpp		FAILURE
​ncomp_incomplete_type2.cpp		FAILURE
​run_gen_030_06x14_229x428_01476078x30421754_4x4_3_54CD291D.cpp		SUCCESS
		FAILURE	exit code 139	​run_gen_030_06x14_229x428_01476078x30421754_4x4_3_54CD291D-run.log

Common header used in some tests: ​common.h

[cpptester]

Tested revision 579 by chernyaev.arsenij.

Smoke tests

test	stage	result	info	log
​run_linked_ptr_gen_smoke_test.cpp		SUCCESS
		FAILURE	exit code 139	​run_linked_ptr_gen_smoke_test-run.log
​run_smoke_test.cpp		SUCCESS
		SUCCESS
		FAILURE	exit code 1	​run_smoke_test-valgrind.log
		SUCCESS
		FAILURE	exit code 1	​run_smoke_test-asan.log
		WARNING		​run_smoke_test-clang-san.log
		FAILURE	exit code 1	​run_smoke_test-san.log

Common header used in some tests: ​common.h

[cpptester]

Tested revision 580 by chernyaev.arsenij.

Smoke tests

test	stage	result	info	log
​run_linked_ptr_gen_smoke_test.cpp		SUCCESS
		FAILURE	exit code 139	​run_linked_ptr_gen_smoke_test-run.log
​run_smoke_test.cpp		SUCCESS
		FAILURE	exit code 139	​run_smoke_test-run.log

Common header used in some tests: ​common.h

[cpptester]

Tested revision 581 by chernyaev.arsenij.

Main tests

test	stage	result	info	log
​run_gen_030_06x14_229x428_01476078x30421754_4x4_3_54CD291D.cpp		SUCCESS
		FAILURE	exit code 139	​run_gen_030_06x14_229x428_01476078x30421754_4x4_3_54CD291D-run.log

Common header used in some tests: ​common.h

[cpptester]

Tested revision 582 by chernyaev.arsenij.

All tests passed. Good job!

[chernyaev.arsenij]

Исправил тесты. Прошу прощения за неудобства

[Vladimir Rutsky]

Не стоит использовать виртуальные методы в данной задаче. В данном случае базовый класс это приватная деталь реализации, и никто не должен хранить linked_ptr по указателю на базовый класс, и виртуальный деструктор здесь не нужен.

Решение зачтено с небольшим минусом.