Opened 6 years ago
Closed 6 years ago
#283 closed ожидается проверка (задача сдана)
HW 4 Aleksandr Eslikov
Reported by: | Aleksandr Eslikov | Owned by: | rutsky,grabovoy.philipp |
---|---|---|---|
Priority: | проверка | Milestone: | ha4-deadline |
Component: | HA#4 function | Version: | 1.0 |
Keywords: | Cc: |
Description
Change History (9)
comment:1 Changed 6 years ago by
Type: | ожидается проверка → ожидаются исправления |
---|
comment:2 Changed 6 years ago by
Tested revision 637 by eslikov.aleksandr.
Main tests
test | stage | result | info | log |
---|---|---|---|---|
SUCCESS | ||||
FAILURE | exit code 139 | |||
Common header used in some tests: common.h
comment:3 Changed 6 years ago by
Tested revision 648 by eslikov.aleksandr.
All tests passed. Good job!
comment:4 Changed 6 years ago by
Tested revision 649 by eslikov.aleksandr.
All tests passed. Good job!
comment:5 Changed 6 years ago by
Type: | ожидаются исправления → ожидается проверка |
---|
comment:6 Changed 6 years ago by
Type: | ожидается проверка → ожидаются исправления |
---|
Привет!
Несколько замечаний:
- Наследоваться от
std::exception
нужно публично - Для
FunctionWrapperInterface
shared_ptr
избыточен, достаточноunique_ptr
comment:7 Changed 6 years ago by
Tested revision 812 by eslikov.aleksandr.
All tests passed. Good job!
comment:9 Changed 6 years ago by
Resolution: | → задача сдана |
---|---|
Status: | new → closed |
И в самом FunctionWrapperInterface::clone
явно приводить результат к типу smart-поинтера необязательно: компилятор применит неявное преобразование, исходя из типа возвращаемого функцией значения (пока оно не auto
).
Note: See
TracTickets for help on using
tickets.
Tested revision 603 by eslikov.aleksandr.
Smoke tests
test
stage
result
info
log
run_function_smoke_test.cpp
run_function_smoke_test-valgrind.log
run_function_smoke_test-clang-san.log
Common header used in some tests: common.h