HA #5

[logunov.aleksandr]

Здравствуйте! Проверьте, пожалуйста, домашнее задание №5.

[cpptester]

Tested revision 617 by logunov.aleksandr.

Smoke tests

test	stage	result	info	log
​run_smoke_test.cpp		SUCCESS
		SUCCESS
		FAILURE	exit code 1	​run_smoke_test-valgrind.log
		SUCCESS
		FAILURE	exit code 1	​run_smoke_test-asan.log
		SUCCESS
		FAILURE	exit code 1	​run_smoke_test-san.log

Common header used in some tests: ​common.h

[cpptester]

Tested revision 725 by logunov.aleksandr.

Smoke tests

test	stage	result	info	log
​run_smoke_test.cpp		SUCCESS
		FAILURE	exit code 139	​run_smoke_test-run.log

Common header used in some tests: ​common.h

[Vladimir Rutsky]

Александр, исправьте, пожалуйста ваше решение, чтобы оно проходило автотесты.

Если возникают проблемы с отладкой, почему тот или иной тест падает --- пишите, помогу разобраться.

[cpptester]

Tested revision 809 by logunov.aleksandr.

Smoke tests

test	stage	result	info	log
​run_smoke_test.cpp		FAILURE		​run_smoke_test-gcc62.log

Common header used in some tests: ​common.h

[cpptester]

Tested revision 810 by logunov.aleksandr.

Smoke tests

test	stage	result	info	log
​run_smoke_test.cpp		WARNING		​run_smoke_test-gcc62.log
		SUCCESS
		SUCCESS		​run_smoke_test-valgrind.log
		WARNING		​run_smoke_test-gcc62-asan.log
		SUCCESS
		WARNING		​run_smoke_test-clang-san.log
		SUCCESS

Common header used in some tests: ​common.h

[cpptester]

Tested revision 811 by logunov.aleksandr.

Main tests

test	stage	result	info	log
​comp_char_traits_custom.cpp		FAILURE		​comp_char_traits_custom-gcc62.log
​comp_index.cpp		FAILURE		​comp_index-gcc62.log
​comp_index_wide.cpp		FAILURE		​comp_index_wide-gcc62.log
​run_assign_c_str_char_traits_length.cpp		SUCCESS
		FAILURE	exit code 139	​run_assign_c_str_char_traits_length-run.log
​run_aug_plus_c_str_char_traits_length.cpp		SUCCESS
		FAILURE	exit code 139	​run_aug_plus_c_str_char_traits_length-run.log
​run_char_traits_custom.cpp		FAILURE		​run_char_traits_custom-gcc62.log
​run_char_traits_custom_eq.cpp		FAILURE		​run_char_traits_custom_eq-gcc62.log
​run_ctor_c_str_char_traits_length.cpp		SUCCESS
		FAILURE	exit code 139	​run_ctor_c_str_char_traits_length-run.log
​run_ctor_repeat.cpp		SUCCESS
		FAILURE	exit code 139	​run_ctor_repeat-run.log
​run_ctor_repeat_char_traits_assign_count.cpp		SUCCESS
		FAILURE	exit code 139	​run_ctor_repeat_char_traits_assign_count-run.log

Common header used in some tests: ​common.h

[cpptester]

Tested revision 817 by logunov.aleksandr.

Smoke tests

test	stage	result	info	log
​run_smoke_test.cpp		WARNING		​run_smoke_test-gcc62.log
		SUCCESS
		SUCCESS		​run_smoke_test-valgrind.log
		WARNING		​run_smoke_test-gcc62-asan.log
		SUCCESS
		WARNING		​run_smoke_test-clang-san.log
		SUCCESS

Common header used in some tests: ​common.h

[cpptester]

Tested revision 818 by logunov.aleksandr.

Main tests

test	stage	result	info	log
​run_eq_compare.cpp		SUCCESS
		FAILURE	exit code 139	​run_eq_compare-run.log
​run_index_assign_assign.cpp		SUCCESS
		FAILURE	exit code 139	​run_index_assign_assign-run.log
​run_index_assign_no_mem.cpp		SUCCESS
		FAILURE	exit code 139	​run_index_assign_no_mem-run.log
​run_plus.cpp		SUCCESS
		FAILURE	exit code 139	​run_plus-run.log
​run_plus_c_str_no_mem_rev.cpp		SUCCESS
		FAILURE	exit code 139	​run_plus_c_str_no_mem_rev-run.log
​run_plus_char_no_mem_rev.cpp		SUCCESS
		FAILURE	exit code 139	​run_plus_char_no_mem_rev-run.log
​run_plus_const.cpp		SUCCESS
		FAILURE	exit code 139	​run_plus_const-run.log

Common header used in some tests: ​common.h

[cpptester]

Tested revision 819 by logunov.aleksandr.

All tests passed. Good job!

[logunov.aleksandr]

Я исправил решение.
Извините за сильную задержку.

[Vladimir Rutsky]

Замечания:

1. Используйте std::min из <algorithm> вместо собственной реализации.

2. Свободные функции (например int compare_sizes(size_t s1, size_t s2)) по умолчанию имеют внешнюю линковку --- ваше решение не скомпилируется, если будет включено в несколько единиц трансляции. Поместите свободные функции в анонимный неймспейс (namespace { ... }) или сделайте их static.

3. Все операции с буферами строки должны выполняться с ипользованием char traits. Например, копирование буфера у вас не использует char traits:

lazy_basic_string(const CharT* str) 
    {
        buffer_ = std::make_shared<std::vector<CharT>>(str, str + Traits::length(str) + 1);
    }

[cpptester]

Tested revision 835 by logunov.aleksandr.

Main tests

test	stage	result	info	log
​comp_all_sufficient.cpp		SUCCESS
		WARNING		​comp_all_sufficient-clang.log
​comp_assign.cpp		SUCCESS
		WARNING		​comp_assign-clang.log
​comp_assign_move_type.cpp		SUCCESS
		WARNING		​comp_assign_move_type-clang.log
​comp_assign_move_type_wide.cpp		SUCCESS
		WARNING		​comp_assign_move_type_wide-clang.log
​comp_assign_type.cpp		SUCCESS
		WARNING		​comp_assign_type-clang.log
​comp_assign_type_wide.cpp		SUCCESS
		WARNING		​comp_assign_type_wide-clang.log
​comp_aug_assign_c_str.cpp		SUCCESS
		WARNING		​comp_aug_assign_c_str-clang.log
​comp_aug_assign_c_str_type.cpp		SUCCESS
		WARNING		​comp_aug_assign_c_str_type-clang.log
​comp_aug_assign_c_wstr.cpp		SUCCESS
		WARNING		​comp_aug_assign_c_wstr-clang.log
​comp_aug_assign_c_wstr_type.cpp		SUCCESS
		WARNING		​comp_aug_assign_c_wstr_type-clang.log

Common header used in some tests: ​common.h

[cpptester]

Tested revision 836 by logunov.aleksandr.

Main tests

test	stage	result	info	log
​run_index_assign_assign.cpp		SUCCESS
		FAILURE	exit code 139	​run_index_assign_assign-run.log

Common header used in some tests: ​common.h

[cpptester]

Tested revision 837 by logunov.aleksandr.

All tests passed. Good job!

[Vladimir Rutsky]

Решение зачтено.

[logunov.aleksandr]

Спасибо!