Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#289 closed ожидаются исправления (задача сдана)

HA #5

Reported by: logunov.aleksandr Owned by: rutsky,grabovoy.philipp
Priority: проверка Milestone: ha5-deadline
Component: HA#5 lazy_string Version: 1.0
Keywords: Cc:

Description

Здравствуйте! Проверьте, пожалуйста, домашнее задание №5.

Change History (17)

comment:1 Changed 3 years ago by cpptester

Type: ожидается проверкаожидаются исправления

Tested revision 617 by logunov.aleksandr.

Smoke tests

test

stage

result

info

log

run_smoke_test.cpp

SUCCESS
SUCCESS
FAILURE

exit code 1

run_smoke_test-valgrind.log

SUCCESS
FAILURE

exit code 1

run_smoke_test-asan.log

SUCCESS
FAILURE

exit code 1

run_smoke_test-san.log

Common header used in some tests: common.h

comment:2 Changed 3 years ago by cpptester

Tested revision 725 by logunov.aleksandr.

Smoke tests

test

stage

result

info

log

run_smoke_test.cpp

SUCCESS
FAILURE

exit code 139

run_smoke_test-run.log

Common header used in some tests: common.h

comment:3 Changed 3 years ago by Vladimir Rutsky

Александр, исправьте, пожалуйста ваше решение, чтобы оно проходило автотесты.

Если возникают проблемы с отладкой, почему тот или иной тест падает --- пишите, помогу разобраться.

comment:4 Changed 3 years ago by cpptester

Tested revision 809 by logunov.aleksandr.

Smoke tests

test

stage

result

info

log

run_smoke_test.cpp

FAILURE

run_smoke_test-gcc62.log

Common header used in some tests: common.h

comment:5 Changed 3 years ago by cpptester

Tested revision 810 by logunov.aleksandr.

Smoke tests

test

stage

result

info

log

run_smoke_test.cpp

WARNING

run_smoke_test-gcc62.log

SUCCESS
SUCCESS

run_smoke_test-valgrind.log

WARNING

run_smoke_test-gcc62-asan.log

SUCCESS
WARNING

run_smoke_test-clang-san.log

SUCCESS

Common header used in some tests: common.h

comment:7 Changed 3 years ago by cpptester

Tested revision 817 by logunov.aleksandr.

Smoke tests

test

stage

result

info

log

run_smoke_test.cpp

WARNING

run_smoke_test-gcc62.log

SUCCESS
SUCCESS

run_smoke_test-valgrind.log

WARNING

run_smoke_test-gcc62-asan.log

SUCCESS
WARNING

run_smoke_test-clang-san.log

SUCCESS

Common header used in some tests: common.h

comment:8 Changed 3 years ago by cpptester

Tested revision 818 by logunov.aleksandr.

Main tests

test

stage

result

info

log

run_eq_compare.cpp

SUCCESS
FAILURE

exit code 139

run_eq_compare-run.log

run_index_assign_assign.cpp

SUCCESS
FAILURE

exit code 139

run_index_assign_assign-run.log

run_index_assign_no_mem.cpp

SUCCESS
FAILURE

exit code 139

run_index_assign_no_mem-run.log

run_plus.cpp

SUCCESS
FAILURE

exit code 139

run_plus-run.log

run_plus_c_str_no_mem_rev.cpp

SUCCESS
FAILURE

exit code 139

run_plus_c_str_no_mem_rev-run.log

run_plus_char_no_mem_rev.cpp

SUCCESS
FAILURE

exit code 139

run_plus_char_no_mem_rev-run.log

run_plus_const.cpp

SUCCESS
FAILURE

exit code 139

run_plus_const-run.log

Common header used in some tests: common.h

comment:9 Changed 3 years ago by cpptester

Tested revision 819 by logunov.aleksandr.

All tests passed. Good job!

comment:10 Changed 3 years ago by logunov.aleksandr

Я исправил решение.
Извините за сильную задержку.

comment:11 Changed 3 years ago by Vladimir Rutsky

Type: ожидаются исправленияожидается проверка

comment:12 Changed 3 years ago by Vladimir Rutsky

Milestone: ha5-milestone2ha5-deadline
Type: ожидается проверкаожидаются исправления

Замечания:

  1. Используйте std::min из <algorithm> вместо собственной реализации.
  1. Свободные функции (например int compare_sizes(size_t s1, size_t s2)) по умолчанию имеют внешнюю линковку --- ваше решение не скомпилируется, если будет включено в несколько единиц трансляции. Поместите свободные функции в анонимный неймспейс (namespace { ... }) или сделайте их static.
  1. Все операции с буферами строки должны выполняться с ипользованием char traits. Например, копирование буфера у вас не использует char traits:
lazy_basic_string(const CharT* str) 
    {
        buffer_ = std::make_shared<std::vector<CharT>>(str, str + Traits::length(str) + 1);
    }

comment:14 Changed 3 years ago by cpptester

Tested revision 836 by logunov.aleksandr.

Main tests

test

stage

result

info

log

run_index_assign_assign.cpp

SUCCESS
FAILURE

exit code 139

run_index_assign_assign-run.log

Common header used in some tests: common.h

comment:15 Changed 3 years ago by cpptester

Tested revision 837 by logunov.aleksandr.

All tests passed. Good job!

comment:16 Changed 3 years ago by Vladimir Rutsky

Resolution: задача сдана
Status: newclosed

Решение зачтено.

comment:17 Changed 3 years ago by logunov.aleksandr

Спасибо!

Note: See TracTickets for help on using tickets.