Opened 3 years ago

Closed 3 years ago

#290 closed ожидается проверка (задача сдана)

HW 5

Reported by: Илья Куроптев Owned by: rutsky,grabovoy.philipp
Priority: проверка Milestone: ha5-deadline
Component: HA#5 lazy_string Version:
Keywords: Cc:

Description


Change History (18)

comment:1 Changed 3 years ago by Vladimir Rutsky

Илья, я не могу найти ваше решение в репозитории svn, вы уверены, что закоммитили его?

comment:2 Changed 3 years ago by cpptester

Type: ожидается проверкаожидаются исправления

Tested revision 680 by kuroptev.ilya.

Smoke tests

test

stage

result

info

log

run_smoke_test.cpp

SUCCESS
FAILURE

exit code 139

run_smoke_test-run.log

Common header used in some tests: common.h

comment:3 Changed 3 years ago by cpptester

Tested revision 686 by kuroptev.ilya.

Smoke tests

test

stage

result

info

log

run_smoke_test.cpp

SUCCESS
SUCCESS
FAILURE

exit code 1

run_smoke_test-valgrind.log

SUCCESS
FAILURE

exit code 1

run_smoke_test-asan.log

SUCCESS
FAILURE

exit code 1

run_smoke_test-san.log

Common header used in some tests: common.h

comment:6 Changed 3 years ago by cpptester

Tested revision 754 by kuroptev.ilya.

Smoke tests

test

stage

result

info

log

run_smoke_test.cpp

SUCCESS
SUCCESS
FAILURE

exit code 1

run_smoke_test-valgrind.log

SUCCESS
FAILURE

exit code 1

run_smoke_test-asan.log

SUCCESS
FAILURE

exit code 1

run_smoke_test-san.log

Common header used in some tests: common.h

comment:7 Changed 3 years ago by cpptester

Tested revision 755 by kuroptev.ilya.

Main tests

test

stage

result

info

log

ncomp_c_str_const.cpp

FAILURE

run_clear.cpp

SUCCESS
FAILURE

exit code 139

run_clear-run.log

run_clear_linked.cpp

SUCCESS
FAILURE

exit code 139

run_clear_linked-run.log

run_clear_wide.cpp

SUCCESS
FAILURE

exit code 139

run_clear_wide-run.log

run_index_assign_assign.cpp

SUCCESS
FAILURE

exit code 139

run_index_assign_assign-run.log

run_index_assign_no_mem.cpp

SUCCESS
FAILURE

exit code 139

run_index_assign_no_mem-run.log

run_lazy_istring_less.cpp

SUCCESS
FAILURE

exit code 139

run_lazy_istring_less-run.log

run_lazy_istring_less2.cpp

SUCCESS
FAILURE

exit code 139

run_lazy_istring_less2-run.log

run_lazy_istring_less2_rev.cpp

SUCCESS
FAILURE

exit code 139

run_lazy_istring_less2_rev-run.log

run_lazy_istring_less_rev.cpp

SUCCESS
FAILURE

exit code 139

run_lazy_istring_less_rev-run.log

Common header used in some tests: common.h

comment:8 Changed 3 years ago by cpptester

Tested revision 756 by kuroptev.ilya.

Smoke tests

test

stage

result

info

log

run_smoke_test.cpp

WARNING

run_smoke_test-gcc62.log

FAILURE

exit code 139

run_smoke_test-run.log

Common header used in some tests: common.h

comment:9 Changed 3 years ago by cpptester

Tested revision 757 by kuroptev.ilya.

Smoke tests

test

stage

result

info

log

run_smoke_test.cpp

WARNING

run_smoke_test-gcc62.log

SUCCESS
SUCCESS

run_smoke_test-valgrind.log

WARNING

run_smoke_test-gcc62-asan.log

SUCCESS
WARNING

run_smoke_test-clang-san.log

SUCCESS

Common header used in some tests: common.h

comment:10 Changed 3 years ago by cpptester

Tested revision 758 by kuroptev.ilya.

Main tests

test

stage

result

info

log

ncomp_iostream_include.cpp

FAILURE

run_clear.cpp

SUCCESS
FAILURE

exit code 139

run_clear-run.log

run_clear_linked.cpp

SUCCESS
FAILURE

exit code 139

run_clear_linked-run.log

run_clear_wide.cpp

SUCCESS
FAILURE

exit code 139

run_clear_wide-run.log

run_ctor_lazy_str_empty.cpp

SUCCESS
FAILURE

exit code 139

run_ctor_lazy_str_empty-run.log

run_ctor_no_mem.cpp

SUCCESS
FAILURE

exit code 139

run_ctor_no_mem-run.log

run_empty.cpp

SUCCESS
FAILURE

exit code 139

run_empty-run.log

run_empty_eq.cpp

SUCCESS
FAILURE

exit code 139

run_empty_eq-run.log

run_empty_wide.cpp

SUCCESS
SUCCESS
FAILURE

exit code 1

run_empty_wide-valgrind.log

SUCCESS
FAILURE

exit code 1

run_empty_wide-asan.log

SUCCESS
SUCCESS

run_less.cpp

SUCCESS
FAILURE

exit code 139

run_less-run.log

Common header used in some tests: common.h

comment:11 Changed 3 years ago by cpptester

Tested revision 759 by kuroptev.ilya.

Main tests

test

stage

result

info

log

run_clear.cpp

SUCCESS
SUCCESS
FAILURE

exit code 1

run_clear-valgrind.log

SUCCESS
SUCCESS
SUCCESS
FAILURE

exit code 1

run_clear-san.log

run_clear_linked.cpp

SUCCESS
SUCCESS
FAILURE

exit code 1

run_clear_linked-valgrind.log

SUCCESS
SUCCESS
SUCCESS
FAILURE

exit code 1

run_clear_linked-san.log

run_clear_wide.cpp

SUCCESS
FAILURE

exit code 139

run_clear_wide-run.log

run_ctor_no_mem.cpp

SUCCESS
FAILURE

exit code 139

run_ctor_no_mem-run.log

run_empty.cpp

SUCCESS
FAILURE

exit code 139

run_empty-run.log

run_empty_eq.cpp

SUCCESS
SUCCESS
FAILURE

exit code 1

run_empty_eq-valgrind.log

SUCCESS
SUCCESS
SUCCESS
FAILURE

exit code 1

run_empty_eq-san.log

run_empty_index_null_char.cpp

SUCCESS
SUCCESS
FAILURE

exit code 1

run_empty_index_null_char-valgrind.log

SUCCESS
FAILURE

exit code 1

run_empty_index_null_char-asan.log

SUCCESS
SUCCESS

run_empty_wide.cpp

SUCCESS
FAILURE

exit code 139

run_empty_wide-run.log

run_not_empty.cpp

SUCCESS
FAILURE

exit code 139

run_not_empty-run.log

run_swap_istring.cpp

FAILURE

run_swap_istring-gcc62.log

Common header used in some tests: common.h

comment:12 Changed 3 years ago by cpptester

Tested revision 760 by kuroptev.ilya.

All tests passed. Good job!

comment:13 Changed 3 years ago by cpptester

Tested revision 761 by kuroptev.ilya.

All tests passed. Good job!

comment:14 Changed 3 years ago by Илья Куроптев

Type: ожидаются исправленияожидается проверка

comment:15 Changed 3 years ago by Vladimir Rutsky

Milestone: ha5-deadline
Type: ожидается проверкаожидаются исправления

Замечания:

  1. Проверки, что результат new[] это nullptr излишни:
CharT * new_pointer = new CharT[1];
if (new_pointer != nullptr)

Думаю, что это условие никогда не будет выполнено (и в большинстве реализаций даже для new[0]).

  1. lazy_istring стоит реализовать как lazy_basic_string<char, details::case_insensitive_char_traits> с вашей реализацией details::case_insensitive_char_traits, где сравнение будет регистронезависимым.

comment:16 Changed 3 years ago by cpptester

Tested revision 800 by kuroptev.ilya.

All tests passed. Good job!

comment:17 Changed 3 years ago by Илья Куроптев

Type: ожидаются исправленияожидается проверка

comment:18 Changed 3 years ago by Vladimir Rutsky

Resolution: задача сдана
Status: newclosed

Решение зачтено.

Note: See TracTickets for help on using tickets.