HW 5

[Vladimir Rutsky]

Илья, я не могу найти ваше решение в репозитории svn, вы уверены, что закоммитили его?

[cpptester]

Tested revision 680 by kuroptev.ilya.

Smoke tests

test	stage	result	info	log
​run_smoke_test.cpp		SUCCESS
		FAILURE	exit code 139	​run_smoke_test-run.log

Common header used in some tests: ​common.h

[cpptester]

Tested revision 686 by kuroptev.ilya.

Smoke tests

test	stage	result	info	log
​run_smoke_test.cpp		SUCCESS
		SUCCESS
		FAILURE	exit code 1	​run_smoke_test-valgrind.log
		SUCCESS
		FAILURE	exit code 1	​run_smoke_test-asan.log
		SUCCESS
		FAILURE	exit code 1	​run_smoke_test-san.log

Common header used in some tests: ​common.h

[cpptester]

Tested revision 687 by kuroptev.ilya.

Main tests

test	stage	result	info	log
​comp_c_str_const.cpp		FAILURE		​comp_c_str_const-gcc62.log
​comp_char_traits_custom.cpp		FAILURE		​comp_char_traits_custom-gcc62.log
​run_assign_c_str_no_mem.cpp		SUCCESS
		FAILURE	exit code 139	​run_assign_c_str_no_mem-run.log
​run_assign_doesnt_compare.cpp		FAILURE		​run_assign_doesnt_compare-gcc62.log
​run_aug_plus_c_str_char_traits_no_mem.cpp		SUCCESS
		FAILURE	exit code 139	​run_aug_plus_c_str_char_traits_no_mem-run.log
​run_aug_plus_c_str_no_mem.cpp		SUCCESS
		FAILURE	exit code 139	​run_aug_plus_c_str_no_mem-run.log
​run_aug_plus_c_wstr_no_mem.cpp		SUCCESS
		FAILURE	exit code 139	​run_aug_plus_c_wstr_no_mem-run.log
​run_aug_plus_char_char_traits_no_mem.cpp		SUCCESS
		FAILURE	exit code 139	​run_aug_plus_char_char_traits_no_mem-run.log
​run_aug_plus_char_no_mem.cpp		SUCCESS
		FAILURE	exit code 139	​run_aug_plus_char_no_mem-run.log
​run_aug_plus_lazy_str_char_traits_no_mem.cpp		SUCCESS
		FAILURE	exit code 139	​run_aug_plus_lazy_str_char_traits_no_mem-run.log

Common header used in some tests: ​common.h

[cpptester]

Tested revision 688 by kuroptev.ilya.

Main tests

test	stage	result	info	log
​comp_char_traits_custom.cpp		FAILURE		​comp_char_traits_custom-gcc62.log
​ncomp_c_str_const.cpp		FAILURE
​run_assign_c_str_no_mem.cpp		SUCCESS
		FAILURE	exit code 139	​run_assign_c_str_no_mem-run.log
​run_assign_doesnt_compare.cpp		FAILURE		​run_assign_doesnt_compare-gcc62.log
​run_aug_plus_c_str_char_traits_no_mem.cpp		SUCCESS
		FAILURE	exit code 139	​run_aug_plus_c_str_char_traits_no_mem-run.log
​run_aug_plus_c_str_no_mem.cpp		SUCCESS
		FAILURE	exit code 139	​run_aug_plus_c_str_no_mem-run.log
​run_aug_plus_c_wstr_no_mem.cpp		SUCCESS
		FAILURE	exit code 139	​run_aug_plus_c_wstr_no_mem-run.log
​run_aug_plus_char_char_traits_no_mem.cpp		SUCCESS
		FAILURE	exit code 139	​run_aug_plus_char_char_traits_no_mem-run.log
​run_aug_plus_char_no_mem.cpp		SUCCESS
		FAILURE	exit code 139	​run_aug_plus_char_no_mem-run.log
​run_aug_plus_lazy_str_char_traits_no_mem.cpp		SUCCESS
		FAILURE	exit code 139	​run_aug_plus_lazy_str_char_traits_no_mem-run.log

Common header used in some tests: ​common.h

[cpptester]

Tested revision 754 by kuroptev.ilya.

Smoke tests

test	stage	result	info	log
​run_smoke_test.cpp		SUCCESS
		SUCCESS
		FAILURE	exit code 1	​run_smoke_test-valgrind.log
		SUCCESS
		FAILURE	exit code 1	​run_smoke_test-asan.log
		SUCCESS
		FAILURE	exit code 1	​run_smoke_test-san.log

Common header used in some tests: ​common.h

[cpptester]

Tested revision 755 by kuroptev.ilya.

Main tests

test	stage	result	info	log
​ncomp_c_str_const.cpp		FAILURE
​run_clear.cpp		SUCCESS
		FAILURE	exit code 139	​run_clear-run.log
​run_clear_linked.cpp		SUCCESS
		FAILURE	exit code 139	​run_clear_linked-run.log
​run_clear_wide.cpp		SUCCESS
		FAILURE	exit code 139	​run_clear_wide-run.log
​run_index_assign_assign.cpp		SUCCESS
		FAILURE	exit code 139	​run_index_assign_assign-run.log
​run_index_assign_no_mem.cpp		SUCCESS
		FAILURE	exit code 139	​run_index_assign_no_mem-run.log
​run_lazy_istring_less.cpp		SUCCESS
		FAILURE	exit code 139	​run_lazy_istring_less-run.log
​run_lazy_istring_less2.cpp		SUCCESS
		FAILURE	exit code 139	​run_lazy_istring_less2-run.log
​run_lazy_istring_less2_rev.cpp		SUCCESS
		FAILURE	exit code 139	​run_lazy_istring_less2_rev-run.log
​run_lazy_istring_less_rev.cpp		SUCCESS
		FAILURE	exit code 139	​run_lazy_istring_less_rev-run.log

Common header used in some tests: ​common.h

[cpptester]

Tested revision 756 by kuroptev.ilya.

Smoke tests

test	stage	result	info	log
​run_smoke_test.cpp		WARNING		​run_smoke_test-gcc62.log
		FAILURE	exit code 139	​run_smoke_test-run.log

Common header used in some tests: ​common.h

[cpptester]

Tested revision 757 by kuroptev.ilya.

Smoke tests

test	stage	result	info	log
​run_smoke_test.cpp		WARNING		​run_smoke_test-gcc62.log
		SUCCESS
		SUCCESS		​run_smoke_test-valgrind.log
		WARNING		​run_smoke_test-gcc62-asan.log
		SUCCESS
		WARNING		​run_smoke_test-clang-san.log
		SUCCESS

Common header used in some tests: ​common.h

[cpptester]

Tested revision 758 by kuroptev.ilya.

Main tests

test	stage	result	info	log
​ncomp_iostream_include.cpp		FAILURE
​run_clear.cpp		SUCCESS
		FAILURE	exit code 139	​run_clear-run.log
​run_clear_linked.cpp		SUCCESS
		FAILURE	exit code 139	​run_clear_linked-run.log
​run_clear_wide.cpp		SUCCESS
		FAILURE	exit code 139	​run_clear_wide-run.log
​run_ctor_lazy_str_empty.cpp		SUCCESS
		FAILURE	exit code 139	​run_ctor_lazy_str_empty-run.log
​run_ctor_no_mem.cpp		SUCCESS
		FAILURE	exit code 139	​run_ctor_no_mem-run.log
​run_empty.cpp		SUCCESS
		FAILURE	exit code 139	​run_empty-run.log
​run_empty_eq.cpp		SUCCESS
		FAILURE	exit code 139	​run_empty_eq-run.log
​run_empty_wide.cpp		SUCCESS
		SUCCESS
		FAILURE	exit code 1	​run_empty_wide-valgrind.log
		SUCCESS
		FAILURE	exit code 1	​run_empty_wide-asan.log
		SUCCESS
		SUCCESS
​run_less.cpp		SUCCESS
		FAILURE	exit code 139	​run_less-run.log

Common header used in some tests: ​common.h

[cpptester]

Tested revision 759 by kuroptev.ilya.

Main tests

test	stage	result	info	log
​run_clear.cpp		SUCCESS
		SUCCESS
		FAILURE	exit code 1	​run_clear-valgrind.log
		SUCCESS
		SUCCESS
		SUCCESS
		FAILURE	exit code 1	​run_clear-san.log
​run_clear_linked.cpp		SUCCESS
		SUCCESS
		FAILURE	exit code 1	​run_clear_linked-valgrind.log
		SUCCESS
		SUCCESS
		SUCCESS
		FAILURE	exit code 1	​run_clear_linked-san.log
​run_clear_wide.cpp		SUCCESS
		FAILURE	exit code 139	​run_clear_wide-run.log
​run_ctor_no_mem.cpp		SUCCESS
		FAILURE	exit code 139	​run_ctor_no_mem-run.log
​run_empty.cpp		SUCCESS
		FAILURE	exit code 139	​run_empty-run.log
​run_empty_eq.cpp		SUCCESS
		SUCCESS
		FAILURE	exit code 1	​run_empty_eq-valgrind.log
		SUCCESS
		SUCCESS
		SUCCESS
		FAILURE	exit code 1	​run_empty_eq-san.log
​run_empty_index_null_char.cpp		SUCCESS
		SUCCESS
		FAILURE	exit code 1	​run_empty_index_null_char-valgrind.log
		SUCCESS
		FAILURE	exit code 1	​run_empty_index_null_char-asan.log
		SUCCESS
		SUCCESS
​run_empty_wide.cpp		SUCCESS
		FAILURE	exit code 139	​run_empty_wide-run.log
​run_not_empty.cpp		SUCCESS
		FAILURE	exit code 139	​run_not_empty-run.log
​run_swap_istring.cpp		FAILURE		​run_swap_istring-gcc62.log

Common header used in some tests: ​common.h

[cpptester]

Tested revision 760 by kuroptev.ilya.

All tests passed. Good job!

[cpptester]

Tested revision 761 by kuroptev.ilya.

All tests passed. Good job!

[Vladimir Rutsky]

Замечания:

1. Проверки, что результат new[] это nullptr излишни:

CharT * new_pointer = new CharT[1];
if (new_pointer != nullptr)

Думаю, что это условие никогда не будет выполнено (и в большинстве реализаций даже для new[0]).

2. lazy_istring стоит реализовать как lazy_basic_string<char, details::case_insensitive_char_traits> с вашей реализацией details::case_insensitive_char_traits, где сравнение будет регистронезависимым.

[cpptester]

Tested revision 800 by kuroptev.ilya.

All tests passed. Good job!

[Vladimir Rutsky]

Решение зачтено.