Opened 3 years ago

Closed 3 years ago

#292 closed ожидается проверка (задача сдана)

Hw 5

Reported by: Igor Ryabtsev Owned by: rutsky,grabovoy.philipp
Priority: проверка Milestone: ha5-milestone2
Component: HA#5 lazy_string Version: 1.0
Keywords: Cc:

Description

Добрый вечер, прошу проверить домашнее задание №5.

Change History (6)

comment:1 Changed 3 years ago by cpptester

Type: ожидается проверкаожидаются исправления

Tested revision 618 by ryabtsev.igor.

Smoke tests

test

stage

result

info

log

run_smoke_test.cpp

WARNING

run_smoke_test-gcc62.log

SUCCESS
SUCCESS

run_smoke_test-valgrind.log

WARNING

run_smoke_test-gcc62-asan.log

SUCCESS
WARNING

run_smoke_test-clang-san.log

SUCCESS

Common header used in some tests: common.h

comment:2 Changed 3 years ago by Igor Ryabtsev

Type: ожидаются исправленияожидается проверка

comment:3 Changed 3 years ago by cpptester

Type: ожидается проверкаожидаются исправления

Tested revision 639 by ryabtsev.igor.

Main tests

test

stage

result

info

log

run_char_traits_custom_eq.cpp

FAILURE

run_char_traits_custom_eq-gcc62.log

run_clear.cpp

SUCCESS
FAILURE

exit code 139

run_clear-run.log

run_clear_linked.cpp

SUCCESS
FAILURE

exit code 139

run_clear_linked-run.log

run_clear_wide.cpp

SUCCESS
FAILURE

exit code 139

run_clear_wide-run.log

Common header used in some tests: common.h

comment:4 Changed 3 years ago by Igor Ryabtsev

Type: ожидаются исправленияожидается проверка

comment:5 Changed 3 years ago by cpptester

Tested revision 641 by ryabtsev.igor.

All tests passed. Good job!

comment:6 Changed 3 years ago by Vladimir Rutsky

Resolution: задача сдана
Status: newclosed

Замечания:

  1. Вместо 0 стоит использовать nullptr.
        lazy_basic_string(const charT str[])
        {
            if(str != 0)
...
  1. proxy_char::is_array_has_single_pointer_owner() стоило сделать приватным.

Решение зачтено.

Note: See TracTickets for help on using tickets.