HA6: bind

[goncharov.artem]

Проверьте, пожалуйста.

[cpptester]

Tested revision 780 by goncharov.artem.

Smoke tests

test	stage	result	info	log
​run_bind_smoke_test.cpp		FAILURE		​run_bind_smoke_test-gcc62.log

Common header used in some tests: ​common.h

[cpptester]

Tested revision 782 by goncharov.artem.

Smoke tests

test	stage	result	info	log
​run_bind_smoke_test.cpp		WARNING		​run_bind_smoke_test-gcc62.log
		SUCCESS
		SUCCESS		​run_bind_smoke_test-valgrind.log
		WARNING		​run_bind_smoke_test-gcc62-asan.log
		SUCCESS
		WARNING		​run_bind_smoke_test-clang-san.log
		SUCCESS

Common header used in some tests: ​common.h

[cpptester]

Tested revision 783 by goncharov.artem.

Smoke tests

test	stage	result	info	log
​run_bind_smoke_test.cpp		WARNING		​run_bind_smoke_test-gcc62.log
		SUCCESS
		SUCCESS		​run_bind_smoke_test-valgrind.log
		WARNING		​run_bind_smoke_test-gcc62-asan.log
		SUCCESS
		SUCCESS
		SUCCESS

Common header used in some tests: ​common.h

[cpptester]

Tested revision 784 by goncharov.artem.

Main tests

test	stage	result	info	log
​comp_all_sufficient.cpp		FAILURE		​comp_all_sufficient-gcc62.log
​comp_include_guard.cpp		FAILURE		​comp_include_guard-gcc62.log
​comp_placeholders_linkage.cpp		FAILURE		​comp_placeholders_linkage-gcc62.log
​ncomp_bind_missing_arg.cpp		FAILURE
​run_lvalue_store.cpp		FAILURE		​run_lvalue_store-gcc62.log
​run_lvalue_store2.cpp		FAILURE		​run_lvalue_store2-gcc62.log
​run_lvalue_store2_const.cpp		FAILURE		​run_lvalue_store2_const-gcc62.log

Common header used in some tests: ​common.h

[cpptester]

Tested revision 785 by goncharov.artem.

Main tests

test	stage	result	info	log
​ncomp_bind_missing_arg.cpp		FAILURE
​ncomp_bind_missing_arg2.cpp		FAILURE

Common header used in some tests: ​common.h

[cpptester]

Tested revision 786 by goncharov.artem.

All tests passed. Good job!

[Vladimir Rutsky]

Замечания:

1. Вместо std::int32_t используйте size_t для индексов.

2. Сейчас плейсхолдеры имеют внешнюю линковку --- ваше решение не слинкуется, если несколько единиц трансляций будут использовать bind.hpp:

 Placeholder<0> _1;
 Placeholder<1> _2;

Сделайте их статическими (либо используя static, либо const).

3. В плейсхолдерах не требуется статическое поле value --- вы его не используете, а производите выбор по шаблонному параметру.

Исправьте, пожалуйста.

[cpptester]

Tested revision 795 by goncharov.artem.

Main tests

test	stage	result	info	log
​comp_all_sufficient.cpp		WARNING		​comp_all_sufficient-gcc62.log
		SUCCESS
​comp_include_guard.cpp		WARNING		​comp_include_guard-gcc62.log
		SUCCESS
​comp_placeholders_linkage.cpp		WARNING		​comp_placeholders_linkage-gcc62.log
		SUCCESS
​run_lvalue_store.cpp		WARNING		​run_lvalue_store-gcc62.log
		SUCCESS
		SUCCESS		​run_lvalue_store-valgrind.log
		WARNING		​run_lvalue_store-gcc62-asan.log
		SUCCESS
		SUCCESS
		SUCCESS
​run_lvalue_store2.cpp		WARNING		​run_lvalue_store2-gcc62.log
		SUCCESS
		SUCCESS		​run_lvalue_store2-valgrind.log
		WARNING		​run_lvalue_store2-gcc62-asan.log
		SUCCESS
		SUCCESS
		SUCCESS
​run_lvalue_store2_const.cpp		WARNING		​run_lvalue_store2_const-gcc62.log
		SUCCESS
		SUCCESS		​run_lvalue_store2_const-valgrind.log
		WARNING		​run_lvalue_store2_const-gcc62-asan.log
		SUCCESS
		SUCCESS
		SUCCESS
​run_pass_rvalue.cpp		WARNING		​run_pass_rvalue-gcc62.log
		SUCCESS
		SUCCESS		​run_pass_rvalue-valgrind.log
		WARNING		​run_pass_rvalue-gcc62-asan.log
		SUCCESS
		SUCCESS
		SUCCESS

Common header used in some tests: ​common.h

[cpptester]

Tested revision 796 by goncharov.artem.

All tests passed. Good job!

[goncharov.artem]

Исправил. Посмотрите, пожалуйста.

[Vladimir Rutsky]

Решение зачтено.