Домашнее задание №3: "Linked ptr"

[Анастасия Семенова]

Проверьте, пожалуйста, домашнее задание №3.
Milestone: 5 декабря.

Ссылка: ​http://trac.compscicenter.ru/svn/cpp16/semyonova.anastasiya/ha3/

[cpptester]

Main tests

test	stage	result	info	log
​comp_reset_derived.cpp	gcc62	FAILURE		​comp_reset_derived-gcc62.log
​ncomp_assign_derived.cpp	gcc62	FAILURE
​ncomp_assign_diff_types.cpp	gcc62	FAILURE
​ncomp_assign_ptr_poly.cpp	gcc62	FAILURE
​ncomp_assign_ptr_poly_const.cpp	gcc62	FAILURE
​ncomp_assign_ptr_prim.cpp	gcc62	FAILURE
​ncomp_assign_ptr_prim_const.cpp	gcc62	FAILURE
​ncomp_assign_ptr_struct.cpp	gcc62	FAILURE
​ncomp_assign_ptr_struct_const.cpp	gcc62	FAILURE
​ncomp_bool_compare.cpp	gcc62	FAILURE

Common header used in some tests: ​common.h

[cpptester]

Main tests

test	stage	result	info	log
​ncomp_assign_derived.cpp	gcc62	FAILURE
​ncomp_assign_diff_types.cpp	gcc62	FAILURE
​ncomp_assign_ptr_poly.cpp	gcc62	FAILURE
​ncomp_assign_ptr_poly_const.cpp	gcc62	FAILURE
​ncomp_assign_ptr_prim.cpp	gcc62	FAILURE
​ncomp_assign_ptr_prim_const.cpp	gcc62	FAILURE
​ncomp_assign_ptr_struct.cpp	gcc62	FAILURE
​ncomp_assign_ptr_struct_const.cpp	gcc62	FAILURE
​ncomp_bool_compare.cpp	gcc62	FAILURE
​ncomp_bool_implicit.cpp	gcc62	FAILURE

Common header used in some tests: ​common.h

[cpptester]

Tested revision 410 by semyonova.anastasiya.

Smoke tests

test	stage	result	info	log
​run_linked_ptr_gen_smoke_test.cpp	gcc62	FAILURE		​run_linked_ptr_gen_smoke_test-gcc62.log
​run_smoke_test.cpp	gcc62	FAILURE		​run_smoke_test-gcc62.log

Common header used in some tests: ​common.h

[cpptester]

Tested revision 412 by semyonova.anastasiya.

Main tests

test	stage	result	info	log
​comp_assign_derived.cpp	gcc62	FAILURE		​comp_assign_derived-gcc62.log
​comp_assign_derived_const.cpp	gcc62	FAILURE		​comp_assign_derived_const-gcc62.log
​ncomp_copy_ctor_from_base1.cpp	gcc62	FAILURE
​ncomp_copy_ctor_from_base1_polymorphic.cpp	gcc62	FAILURE
​ncomp_copy_ctor_from_base2.cpp	gcc62	FAILURE
​ncomp_copy_ctor_from_base2_polymorphic.cpp	gcc62	FAILURE
​ncomp_ctor_const2.cpp	gcc62	FAILURE
​ncomp_ctor_different_types.cpp	gcc62	FAILURE
​ncomp_ctor_from_base.cpp	gcc62	FAILURE
​ncomp_include_iostream.cpp	gcc62	FAILURE

Common header used in some tests: ​common.h

[cpptester]

Tested revision 414 by semyonova.anastasiya.

Smoke tests

test	stage	result	info	log
​run_linked_ptr_gen_smoke_test.cpp	gcc62	FAILURE		​run_linked_ptr_gen_smoke_test-gcc62.log
​run_smoke_test.cpp	gcc62	FAILURE		​run_smoke_test-gcc62.log

Common header used in some tests: ​common.h

[cpptester]

Tested revision 415 by semyonova.anastasiya.

Main tests

test	stage	result	info	log
​comp_assign_derived.cpp	gcc62	FAILURE		​comp_assign_derived-gcc62.log
​comp_assign_derived_const.cpp	gcc62	FAILURE		​comp_assign_derived_const-gcc62.log
​ncomp_copy_ctor_from_base1.cpp	gcc62	FAILURE
​ncomp_copy_ctor_from_base1_polymorphic.cpp	gcc62	FAILURE
​ncomp_copy_ctor_from_base2.cpp	gcc62	FAILURE
​ncomp_copy_ctor_from_base2_polymorphic.cpp	gcc62	FAILURE
​ncomp_ctor_const2.cpp	gcc62	FAILURE
​ncomp_ctor_different_types.cpp	gcc62	FAILURE
​ncomp_ctor_from_base.cpp	gcc62	FAILURE
​ncomp_include_iostream.cpp	gcc62	FAILURE

Common header used in some tests: ​common.h

[cpptester]

Tested revision 416 by semyonova.anastasiya.

Main tests

test	stage	result	info	log
​ncomp_assign_derived.cpp	gcc62	FAILURE
​ncomp_assign_diff_types.cpp	gcc62	FAILURE
​ncomp_copy_ctor_from_base1.cpp	gcc62	FAILURE
​ncomp_copy_ctor_from_base1_polymorphic.cpp	gcc62	FAILURE
​ncomp_copy_ctor_from_base2.cpp	gcc62	FAILURE
​ncomp_copy_ctor_from_base2_polymorphic.cpp	gcc62	FAILURE
​ncomp_ctor_const2.cpp	gcc62	FAILURE
​ncomp_ctor_different_types.cpp	gcc62	FAILURE
​ncomp_ctor_from_base.cpp	gcc62	FAILURE
​ncomp_include_iostream.cpp	gcc62	FAILURE

Common header used in some tests: ​common.h

[cpptester]

Tested revision 440 by semyonova.anastasiya.

Smoke tests

test	stage	result	info	log
​run_smoke_test.cpp	gcc62	SUCCESS
	run	SUCCESS
	valgrind	FAILURE	exit code 1	​run_smoke_test-valgrind.log
	gcc62-asan	SUCCESS
	asan	FAILURE	exit code 1	​run_smoke_test-asan.log
	clang-san	SUCCESS
	san	FAILURE	exit code 1	​run_smoke_test-san.log

Common header used in some tests: ​common.h

[cpptester]

Tested revision 464 by semyonova.anastasiya.

Smoke tests

test	stage	result	info	log
​run_linked_ptr_gen_smoke_test.cpp	gcc62	FAILURE		​run_linked_ptr_gen_smoke_test-gcc62.log
​run_smoke_test.cpp	gcc62	FAILURE		​run_smoke_test-gcc62.log

Common header used in some tests: ​common.h

[cpptester]

Tested revision 466 by semyonova.anastasiya.

Smoke tests

test	stage	result	info	log
​run_linked_ptr_gen_smoke_test.cpp	gcc62	FAILURE		​run_linked_ptr_gen_smoke_test-gcc62.log
​run_smoke_test.cpp	gcc62	FAILURE		​run_smoke_test-gcc62.log

Common header used in some tests: ​common.h

[cpptester]

Tested revision 467 by semyonova.anastasiya.

Main tests

test	stage	result	info	log
​ncomp_include_iostream.cpp	gcc62	FAILURE
​ncomp_incomplete_type1.cpp	gcc62	FAILURE
​ncomp_incomplete_type2.cpp	gcc62	FAILURE
​run_reset_linked.cpp	gcc62	SUCCESS
	run	SUCCESS
	valgrind	FAILURE	exit code 1	​run_reset_linked-valgrind.log
	gcc62-asan	SUCCESS
	asan	FAILURE	exit code 1	​run_reset_linked-asan.log
	clang-san	SUCCESS
	san	FAILURE	exit code 1	​run_reset_linked-san.log
​run_test.cpp	gcc62	SUCCESS
	run	SUCCESS
	valgrind	FAILURE	exit code 1	​run_test-valgrind.log
	gcc62-asan	SUCCESS
	asan	FAILURE	exit code 1	​run_test-asan.log
	clang-san	SUCCESS
	san	FAILURE	exit code 1	​run_test-san.log
​run_test2.cpp	gcc62	SUCCESS
	run	SUCCESS
	valgrind	FAILURE	exit code 1	​run_test2-valgrind.log
	gcc62-asan	SUCCESS
	asan	FAILURE	exit code 1	​run_test2-asan.log
	clang-san	SUCCESS
	san	FAILURE	exit code 1	​run_test2-san.log
​run_unique_both.cpp	gcc62	SUCCESS
	run	FAILURE	exit code 139	​run_unique_both-run.log

Common header used in some tests: ​common.h

[cpptester]

Tested revision 469 by semyonova.anastasiya.

Main tests

test	stage	result	info	log
​ncomp_include_iostream.cpp	gcc62	FAILURE
​ncomp_incomplete_type1.cpp	gcc62	FAILURE
​ncomp_incomplete_type2.cpp	gcc62	FAILURE
​run_reset_linked.cpp	gcc62	SUCCESS
	run	SUCCESS
	valgrind	FAILURE	exit code 1	​run_reset_linked-valgrind.log
	gcc62-asan	SUCCESS
	asan	FAILURE	exit code 1	​run_reset_linked-asan.log
	clang-san	SUCCESS
	san	FAILURE	exit code 1	​run_reset_linked-san.log
​run_test.cpp	gcc62	SUCCESS
	run	SUCCESS
	valgrind	FAILURE	exit code 1	​run_test-valgrind.log
	gcc62-asan	SUCCESS
	asan	FAILURE	exit code 1	​run_test-asan.log
	clang-san	SUCCESS
	san	FAILURE	exit code 1	​run_test-san.log
​run_test2.cpp	gcc62	SUCCESS
	run	SUCCESS
	valgrind	FAILURE	exit code 1	​run_test2-valgrind.log
	gcc62-asan	SUCCESS
	asan	FAILURE	exit code 1	​run_test2-asan.log
	clang-san	SUCCESS
	san	FAILURE	exit code 1	​run_test2-san.log
​run_unique_both.cpp	gcc62	SUCCESS
	run	FAILURE	exit code 139	​run_unique_both-run.log

Common header used in some tests: ​common.h

[cpptester]

Tested revision 471 by semyonova.anastasiya.

Main tests

test	stage	result	info	log
​ncomp_include_iostream.cpp	gcc62	FAILURE
​ncomp_incomplete_type1.cpp	gcc62	FAILURE
​ncomp_incomplete_type2.cpp	gcc62	FAILURE
​run_reset_linked.cpp	gcc62	SUCCESS
	run	SUCCESS
	valgrind	FAILURE	exit code 1	​run_reset_linked-valgrind.log
	gcc62-asan	SUCCESS
	asan	FAILURE	exit code 1	​run_reset_linked-asan.log
	clang-san	SUCCESS
	san	FAILURE	exit code 1	​run_reset_linked-san.log
​run_test.cpp	gcc62	SUCCESS
	run	SUCCESS
	valgrind	FAILURE	exit code 1	​run_test-valgrind.log
	gcc62-asan	SUCCESS
	asan	FAILURE	exit code 1	​run_test-asan.log
	clang-san	SUCCESS
	san	FAILURE	exit code 1	​run_test-san.log
​run_test2.cpp	gcc62	SUCCESS
	run	SUCCESS
	valgrind	FAILURE	exit code 1	​run_test2-valgrind.log
	gcc62-asan	SUCCESS
	asan	FAILURE	exit code 1	​run_test2-asan.log
	clang-san	SUCCESS
	san	FAILURE	exit code 1	​run_test2-san.log
​run_unique_both.cpp	gcc62	SUCCESS
	run	FAILURE	exit code 139	​run_unique_both-run.log

Common header used in some tests: ​common.h

[cpptester]

Tested revision 474 by semyonova.anastasiya.

Smoke tests

test	stage	result	info	log
​run_linked_ptr_gen_smoke_test.cpp	gcc62	WARNING		​run_linked_ptr_gen_smoke_test-gcc62.log
	run	SUCCESS
	valgrind	SUCCESS		​run_linked_ptr_gen_smoke_test-valgrind.log
	gcc62-asan	WARNING		​run_linked_ptr_gen_smoke_test-gcc62-asan.log
	asan	SUCCESS
	clang-san	WARNING		​run_linked_ptr_gen_smoke_test-clang-san.log
	san	SUCCESS
​run_smoke_test.cpp	gcc62	WARNING		​run_smoke_test-gcc62.log
	run	SUCCESS
	valgrind	SUCCESS		​run_smoke_test-valgrind.log
	gcc62-asan	WARNING		​run_smoke_test-gcc62-asan.log
	asan	SUCCESS
	clang-san	WARNING		​run_smoke_test-clang-san.log
	san	SUCCESS

Common header used in some tests: ​common.h

[cpptester]

Tested revision 476 by semyonova.anastasiya.

Smoke tests

test	stage	result	info	log
​run_linked_ptr_gen_smoke_test.cpp	gcc62	SUCCESS
	run	WARNING		​run_linked_ptr_gen_smoke_test-run.log
	valgrind	WARNING		​run_linked_ptr_gen_smoke_test-valgrind.log
	gcc62-asan	SUCCESS
	asan	WARNING		​run_linked_ptr_gen_smoke_test-asan.log
	clang-san	SUCCESS
	san	WARNING		​run_linked_ptr_gen_smoke_test-san.log
​run_smoke_test.cpp	gcc62	SUCCESS
	run	WARNING		​run_smoke_test-run.log
	valgrind	WARNING		​run_smoke_test-valgrind.log
	gcc62-asan	SUCCESS
	asan	WARNING		​run_smoke_test-asan.log
	clang-san	SUCCESS
	san	WARNING		​run_smoke_test-san.log

Common header used in some tests: ​common.h

[cpptester]

Tested revision 477 by semyonova.anastasiya.

Main tests

test	stage	result	info	log
​ncomp_include_iostream.cpp	gcc62	FAILURE
​run_reset_linked.cpp	gcc62	SUCCESS
	run	SUCCESS
	valgrind	FAILURE	exit code 1	​run_reset_linked-valgrind.log
	gcc62-asan	SUCCESS
	asan	FAILURE	exit code 1	​run_reset_linked-asan.log
	clang-san	SUCCESS
	san	FAILURE	exit code 1	​run_reset_linked-san.log
​run_test.cpp	gcc62	SUCCESS
	run	SUCCESS
	valgrind	FAILURE	exit code 1	​run_test-valgrind.log
	gcc62-asan	SUCCESS
	asan	FAILURE	exit code 1	​run_test-asan.log
	clang-san	SUCCESS
	san	FAILURE	exit code 1	​run_test-san.log
​run_test2.cpp	gcc62	SUCCESS
	run	SUCCESS
	valgrind	FAILURE	exit code 1	​run_test2-valgrind.log
	gcc62-asan	SUCCESS
	asan	FAILURE	exit code 1	​run_test2-asan.log
	clang-san	SUCCESS
	san	FAILURE	exit code 1	​run_test2-san.log
​run_unique_both.cpp	gcc62	SUCCESS
	run	FAILURE	exit code 139	​run_unique_both-run.log

Common header used in some tests: ​common.h

[cpptester]

Tested revision 492 by semyonova.anastasiya.

Main tests

test	stage	result	info	log
​ncomp_include_iostream.cpp	gcc62	FAILURE
​run_unique_both.cpp	gcc62	SUCCESS
	run	FAILURE	exit code 139	​run_unique_both-run.log

Common header used in some tests: ​common.h

[cpptester]

Tested revision 493 by semyonova.anastasiya.

Main tests

test	stage	result	info	log
​run_unique_both.cpp	gcc62	SUCCESS
	run	FAILURE	exit code 139	​run_unique_both-run.log

Common header used in some tests: ​common.h

[cpptester]

Tested revision 494 by semyonova.anastasiya.

All tests passed. Good job!

[cpptester]

Tested revision 497 by semyonova.anastasiya.

Main tests

test	stage	result	info	log
​ncomp_incomplete_type1.cpp	gcc62	FAILURE
​ncomp_incomplete_type2.cpp	gcc62	FAILURE

Common header used in some tests: ​common.h

[cpptester]

Tested revision 498 by semyonova.anastasiya.

All tests passed. Good job!

[Анастасия Семенова]

Поправила тесты. Проверьте, пожалуйста.

[Vladimir Rutsky]

Замечания:

1. linked_ptr_wrapper должен находиться в namespace smart_ptr::details.

2. Лучше использовать static_assert здесь:

if (sizeof(T) && false) {
            // This if-branch will cause compilation error if type is incomplete
            return;
        }

Решение зачтено. Бонусное задание не выполнено.

Тест для бонусного задания (должен компилироваться без предупреждений):

#include "linked_ptr.hpp"

struct C;

int main()
{
    // Should compile. Completeness of C is not needed.
    smart_ptr::linked_ptr<C> p1;
    smart_ptr::linked_ptr<C> p2(p1);

    // Shouldn't compile:
    //smart_ptr::linked_ptr<C> p3(reinterpret_cast<C *>(123));
    //p1.reset(reinterpret_cast<C *>(123));
}

[cpptester]

Tested revision 498 by semyonova.anastasiya.

Main tests

test	stage	result	info	log
​run_gen_014_2x6_0x4_041x494_3x4_2x4_4x5_00x13_07x_8A3952A5.cpp	gcc62	FAILURE		​run_gen_014_2x6_0x4_041x494_3x4_2x4_4x5_00x13_07x_8A3952A5-gcc62.log
​run_gen_016_6x7_027x428_70x90_3x4_3x5_2x6_4x7_7x7_94DC920E.cpp	gcc62	FAILURE		​run_gen_016_6x7_027x428_70x90_3x4_3x5_2x6_4x7_7x7_94DC920E-gcc62.log

Common header used in some tests: ​common.h

[cpptester]

Tested revision 498 by semyonova.anastasiya.

Main tests

test	stage	result	info	log
​run_gen_014_2x6_0x4_041x494_3x4_2x4_4x5_00x13_07x_8A3952A5.cpp	gcc62	SUCCESS
	run	SUCCESS
	valgrind	FAILURE	exit code 1	​run_gen_014_2x6_0x4_041x494_3x4_2x4_4x5_00x13_07x_8A3952A5-valgrind.log
	gcc62-asan	SUCCESS
	asan	FAILURE	exit code 1	​run_gen_014_2x6_0x4_041x494_3x4_2x4_4x5_00x13_07x_8A3952A5-asan.log
	clang-san	SUCCESS
	san	FAILURE	exit code 1	​run_gen_014_2x6_0x4_041x494_3x4_2x4_4x5_00x13_07x_8A3952A5-san.log

Common header used in some tests: ​common.h

[cpptester]

Tested revision 570 by semyonova.anastasiya.

Smoke tests

test	stage	result	info	log
​run_linked_ptr_gen_smoke_test.cpp	gcc62	FAILURE		​run_linked_ptr_gen_smoke_test-gcc62.log
​run_smoke_test.cpp	gcc62	FAILURE		​run_smoke_test-gcc62.log

Common header used in some tests: ​common.h

[cpptester]

Tested revision 571 by semyonova.anastasiya.

Main tests

test	stage	result	info	log
​run_gen_014_2x6_0x4_041x494_3x4_2x4_4x5_00x13_07x_8A3952A5.cpp	gcc62	SUCCESS
	run	SUCCESS
	valgrind	FAILURE	exit code 1	​run_gen_014_2x6_0x4_041x494_3x4_2x4_4x5_00x13_07x_8A3952A5-valgrind.log
	gcc62-asan	SUCCESS
	asan	FAILURE	exit code 1	​run_gen_014_2x6_0x4_041x494_3x4_2x4_4x5_00x13_07x_8A3952A5-asan.log
	clang-san	SUCCESS
	san	FAILURE	exit code 1	​run_gen_014_2x6_0x4_041x494_3x4_2x4_4x5_00x13_07x_8A3952A5-san.log

Common header used in some tests: ​common.h

[cpptester]

Tested revision 575 by semyonova.anastasiya.

All tests passed. Good job!

[cpptester]

Tested revision 576 by semyonova.anastasiya.

All tests passed. Good job!

[cpptester]

Tested revision 582 by semyonova.anastasiya.

All tests passed. Good job!

[Vladimir Rutsky]

Решение зачтено.

Бонусное задание не выполнено.

Тест для бонусного задания (должен компилироваться без предупреждений):

#include "linked_ptr.hpp"

struct C;

int main()
{
    // Should compile. Completeness of C is not needed.
    smart_ptr::linked_ptr<C> p1;
    smart_ptr::linked_ptr<C> p2(p1);

    // Shouldn't compile:
    //smart_ptr::linked_ptr<C> p3(reinterpret_cast<C *>(123));
    //p1.reset(reinterpret_cast<C *>(123));
}

[Vladimir Rutsky]

Milestone ha3-milestone1 deleted