Opened 7 years ago

Closed 7 years ago

Last modified 6 years ago

#98 closed ожидается проверка (задача сдана)

ДЗ#3: linked_pointer

Reported by: Viacheslav Kukushkin Owned by: Vladimir Rutsky
Priority: проверка Milestone:
Component: HA#3 linked_ptr Version:
Keywords: Cc:

Description

Проверьте, пожалуйста

Change History (25)

comment:1 Changed 7 years ago by cpptester

Type: ожидается проверкаожидаются исправления

Smoke tests

test

stage

result

info

log

run_linked_ptr_gen_smoke_test.cpp

gcc62

WARNING

run_linked_ptr_gen_smoke_test-gcc62.log

run

SUCCESS

valgrind

SUCCESS

run_linked_ptr_gen_smoke_test-valgrind.log

gcc62-asan

WARNING

run_linked_ptr_gen_smoke_test-gcc62-asan.log

asan

SUCCESS

clang-san

WARNING

run_linked_ptr_gen_smoke_test-clang-san.log

san

WARNING

run_linked_ptr_gen_smoke_test-san.log

run_smoke_test.cpp

gcc62

WARNING

run_smoke_test-gcc62.log

run

SUCCESS

valgrind

SUCCESS

run_smoke_test-valgrind.log

gcc62-asan

WARNING

run_smoke_test-gcc62-asan.log

asan

SUCCESS

clang-san

WARNING

run_smoke_test-clang-san.log

san

WARNING

run_smoke_test-san.log

Common header used in some tests: common.h

comment:2 Changed 7 years ago by cpptester

Tested revision 541 by kukushkin.vyacheslav.

Smoke tests

test

stage

result

info

log

run_linked_ptr_gen_smoke_test.cpp

gcc62

SUCCESS

run

SUCCESS

valgrind

SUCCESS

run_linked_ptr_gen_smoke_test-valgrind.log

gcc62-asan

SUCCESS

asan

SUCCESS

clang-san

SUCCESS

san

WARNING

run_linked_ptr_gen_smoke_test-san.log

run_smoke_test.cpp

gcc62

SUCCESS

run

SUCCESS

valgrind

SUCCESS

run_smoke_test-valgrind.log

gcc62-asan

SUCCESS

asan

SUCCESS

clang-san

SUCCESS

san

WARNING

run_smoke_test-san.log

Common header used in some tests: common.h

comment:3 Changed 7 years ago by cpptester

Tested revision 541 by kukushkin.vyacheslav.

Smoke tests

test

stage

result

info

log

run_linked_ptr_gen_smoke_test.cpp

gcc62

SUCCESS

run

SUCCESS

valgrind

SUCCESS

run_linked_ptr_gen_smoke_test-valgrind.log

gcc62-asan

SUCCESS

asan

SUCCESS

clang-san

SUCCESS

san

WARNING

run_linked_ptr_gen_smoke_test-san.log

run_smoke_test.cpp

gcc62

SUCCESS

run

SUCCESS

valgrind

SUCCESS

run_smoke_test-valgrind.log

gcc62-asan

SUCCESS

asan

SUCCESS

clang-san

SUCCESS

san

WARNING

run_smoke_test-san.log

Common header used in some tests: common.h

comment:4 Changed 7 years ago by Vladimir Rutsky

Вячеслав, теперь в логе есть стек трейс, где видно как именно происходит разыменование нулевого указателя.

comment:7 Changed 7 years ago by cpptester

Tested revision 567 by kukushkin.vyacheslav.

Smoke tests

test

stage

result

info

log

run_linked_ptr_gen_smoke_test.cpp

gcc62

SUCCESS

run

SUCCESS

valgrind

SUCCESS

run_linked_ptr_gen_smoke_test-valgrind.log

gcc62-asan

SUCCESS

asan

SUCCESS

clang-san

SUCCESS

san

WARNING

run_linked_ptr_gen_smoke_test-san.log

run_smoke_test.cpp

gcc62

SUCCESS

run

SUCCESS

valgrind

SUCCESS

run_smoke_test-valgrind.log

gcc62-asan

SUCCESS

asan

SUCCESS

clang-san

SUCCESS

san

WARNING

run_smoke_test-san.log

Common header used in some tests: common.h

comment:11 Changed 7 years ago by cpptester

Tested revision 601 by kukushkin.vyacheslav.

Smoke tests

test

stage

result

info

log

run_linked_ptr_gen_smoke_test.cpp

gcc62

SUCCESS

run

SUCCESS

valgrind

SUCCESS

run_linked_ptr_gen_smoke_test-valgrind.log

gcc62-asan

SUCCESS

asan

SUCCESS

clang-san

SUCCESS

san

WARNING

run_linked_ptr_gen_smoke_test-san.log

run_smoke_test.cpp

gcc62

SUCCESS

run

SUCCESS

valgrind

SUCCESS

run_smoke_test-valgrind.log

gcc62-asan

SUCCESS

asan

SUCCESS

clang-san

SUCCESS

san

WARNING

run_smoke_test-san.log

Common header used in some tests: common.h

comment:14 Changed 7 years ago by cpptester

Tested revision 605 by kukushkin.vyacheslav.

Main tests

test

stage

result

info

log

comp_get_const.cpp

gcc62

FAILURE

comp_get_const-gcc62.log

comp_unique_const.cpp

gcc62

FAILURE

comp_unique_const-gcc62.log

ncomp_assign_derived.cpp

gcc62

FAILURE

ncomp_assign_diff_types.cpp

gcc62

FAILURE

ncomp_cmp_different_types1.cpp

gcc62

FAILURE

ncomp_cmp_different_types2.cpp

gcc62

FAILURE

ncomp_copy_ctor_from_base1.cpp

gcc62

FAILURE

ncomp_copy_ctor_from_base1_polymorphic.cpp

gcc62

FAILURE

ncomp_copy_ctor_from_base2.cpp

gcc62

FAILURE

ncomp_copy_ctor_from_base2_polymorphic.cpp

gcc62

FAILURE

Common header used in some tests: common.h

comment:15 Changed 7 years ago by cpptester

Tested revision 606 by kukushkin.vyacheslav.

Smoke tests

test

stage

result

info

log

run_linked_ptr_gen_smoke_test.cpp

gcc62

FAILURE

run_linked_ptr_gen_smoke_test-gcc62.log

run_smoke_test.cpp

gcc62

FAILURE

run_smoke_test-gcc62.log

Common header used in some tests: common.h

comment:16 Changed 7 years ago by cpptester

Tested revision 607 by kukushkin.vyacheslav.

Smoke tests

test

stage

result

info

log

run_smoke_test.cpp

gcc62

FAILURE

run_smoke_test-gcc62.log

Common header used in some tests: common.h

comment:17 Changed 7 years ago by cpptester

Tested revision 617 by kukushkin.vyacheslav.

Main tests

test

stage

result

info

log

comp_unique_const.cpp

gcc62

FAILURE

comp_unique_const-gcc62.log

ncomp_incomplete_type1.cpp

gcc62

FAILURE

ncomp_incomplete_type2.cpp

gcc62

FAILURE

Common header used in some tests: common.h

comment:18 Changed 7 years ago by cpptester

Tested revision 619 by kukushkin.vyacheslav.

Main tests

test

stage

result

info

log

ncomp_incomplete_type1.cpp

gcc62

FAILURE

ncomp_incomplete_type2.cpp

gcc62

FAILURE

Common header used in some tests: common.h

comment:19 Changed 7 years ago by cpptester

Tested revision 632 by kukushkin.vyacheslav.

All tests passed. Good job!

comment:20 Changed 7 years ago by cpptester

Tested revision 634 by kukushkin.vyacheslav.

All tests passed. Good job!

comment:21 Changed 7 years ago by Viacheslav Kukushkin

Type: ожидаются исправленияожидается проверка

comment:22 Changed 7 years ago by Vladimir Rutsky

Resolution: задача сдана
Status: newclosed

я так и не понял, почему get() должен быть const (а ну как пользователь удалит data ?)
но иначе тесты не проходят
T* get() const {

return data;

}

Константность get() необходима, чтобы пользователь мог получить значение хранимого указателя, даже если объект linked_ptr константный.

Решение зачтено.

comment:23 Changed 7 years ago by Vladimir Rutsky

Бонусное задание не выполнено.

Тест для бонусного задания (должен компилироваться без предупреждений):

#include "linked_ptr.hpp"

struct C;

int main()
{
    // Should compile. Completeness of C is not needed.
    smart_ptr::linked_ptr<C> p1;
    smart_ptr::linked_ptr<C> p2(p1);

    // Shouldn't compile:
    //smart_ptr::linked_ptr<C> p3(reinterpret_cast<C *>(123));
    //p1.reset(reinterpret_cast<C *>(123));
}

comment:24 Changed 7 years ago by Vladimir Rutsky

Milestone: ha3-milestone1

Milestone ha3-milestone1 deleted

comment:25 Changed 6 years ago by cpptester

Tested revision 634 by kukushkin.vyacheslav.

All tests passed. Good job!

Note: See TracTickets for help on using tickets.