Home Assignment 3, linked_ptr

[Филиппов Максим]

Здравствуйте!

Присылаю третье домашнее задание.

Пожалуйста, проверьте.

[cpptester]

Main tests

test	stage	result	info	log
​comp_cmp_less_diff_types1.cpp	gcc62	FAILURE		​comp_cmp_less_diff_types1-gcc62.log
​comp_cmp_less_diff_types2.cpp	gcc62	FAILURE		​comp_cmp_less_diff_types2-gcc62.log
​comp_cmp_less_diff_types_const1.cpp	gcc62	FAILURE		​comp_cmp_less_diff_types_const1-gcc62.log
​comp_cmp_less_diff_types_const2.cpp	gcc62	FAILURE		​comp_cmp_less_diff_types_const2-gcc62.log
​comp_cmp_less_diff_types_const3.cpp	gcc62	FAILURE		​comp_cmp_less_diff_types_const3-gcc62.log
​comp_cmp_less_diff_types_const4.cpp	gcc62	FAILURE		​comp_cmp_less_diff_types_const4-gcc62.log
​comp_cmp_less_diff_types_const5.cpp	gcc62	FAILURE		​comp_cmp_less_diff_types_const5-gcc62.log
​comp_cmp_less_diff_types_const6.cpp	gcc62	FAILURE		​comp_cmp_less_diff_types_const6-gcc62.log
​comp_ctor_NULL.cpp	gcc62	FAILURE		​comp_ctor_NULL-gcc62.log
​comp_ctor_zero.cpp	gcc62	FAILURE		​comp_ctor_zero-gcc62.log

Common header used in some tests: ​common.h

[cpptester]

Tested revision 411 by filippov.maksim.

Main tests

test	stage	result	info	log
​ncomp_incomplete_type1.cpp	gcc62	FAILURE
​ncomp_incomplete_type2.cpp	gcc62	FAILURE
​run_op1.cpp	gcc62	SUCCESS
	run	FAILURE	exit code 139	​run_op1-run.log
​run_swap_adjacent1.cpp	gcc62	SUCCESS
	run	FAILURE	exit code 139	​run_swap_adjacent1-run.log
​run_swap_adjacent2.cpp	gcc62	SUCCESS
	run	SUCCESS
	valgrind	FAILURE	exit code 1	​run_swap_adjacent2-valgrind.log
	gcc62-asan	SUCCESS
	asan	FAILURE	exit code 1	​run_swap_adjacent2-asan.log
	clang-san	SUCCESS
	san	FAILURE	exit code 1	​run_swap_adjacent2-san.log
​run_swap_two_diff2.cpp	gcc62	SUCCESS
	run	SUCCESS
	valgrind	FAILURE	exit code 1	​run_swap_two_diff2-valgrind.log
	gcc62-asan	SUCCESS
	asan	FAILURE	exit code 1	​run_swap_two_diff2-asan.log
	clang-san	SUCCESS
	san	FAILURE	exit code 1	​run_swap_two_diff2-san.log
​run_test.cpp	gcc62	SUCCESS
	run	SUCCESS
	valgrind	FAILURE	exit code 1	​run_test-valgrind.log
	gcc62-asan	SUCCESS
	asan	FAILURE	exit code 1	​run_test-asan.log
	clang-san	SUCCESS
	san	FAILURE	exit code 1	​run_test-san.log
​run_test2.cpp	gcc62	SUCCESS
	run	SUCCESS
	valgrind	FAILURE	exit code 1	​run_test2-valgrind.log
	gcc62-asan	SUCCESS
	asan	FAILURE	exit code 1	​run_test2-asan.log
	clang-san	SUCCESS
	san	FAILURE	exit code 1	​run_test2-san.log

Common header used in some tests: ​common.h

[cpptester]

Tested revision 441 by filippov.maksim.

Smoke tests

test	stage	result	info	log
​run_linked_ptr_gen_smoke_test.cpp	gcc62	WARNING		​run_linked_ptr_gen_smoke_test-gcc62.log
	run	SUCCESS
	valgrind	SUCCESS		​run_linked_ptr_gen_smoke_test-valgrind.log
	gcc62-asan	WARNING		​run_linked_ptr_gen_smoke_test-gcc62-asan.log
	asan	SUCCESS
	clang-san	WARNING		​run_linked_ptr_gen_smoke_test-clang-san.log
	san	SUCCESS
​run_smoke_test.cpp	gcc62	WARNING		​run_smoke_test-gcc62.log
	run	WARNING		​run_smoke_test-run.log
	valgrind	WARNING		​run_smoke_test-valgrind.log
	gcc62-asan	WARNING		​run_smoke_test-gcc62-asan.log
	asan	WARNING		​run_smoke_test-asan.log
	clang-san	WARNING		​run_smoke_test-clang-san.log
	san	WARNING		​run_smoke_test-san.log

Common header used in some tests: ​common.h

[cpptester]

Tested revision 443 by filippov.maksim.

Main tests

test	stage	result	info	log
​ncomp_incomplete_type1.cpp	gcc62	FAILURE
​ncomp_incomplete_type2.cpp	gcc62	FAILURE

Common header used in some tests: ​common.h

[cpptester]

Tested revision 449 by filippov.maksim.

All tests passed. Good job!

[cpptester]

Tested revision 454 by filippov.maksim.

All tests passed. Good job!

[cpptester]

Tested revision 507 by filippov.maksim.

All tests passed. Good job!

[cpptester]

Tested revision 515 by filippov.maksim.

All tests passed. Good job!

[Vladimir Rutsky]

Замечания:

1. linked_ptr не предназначен для наследования, тем более никто не должен обращаться к базовому классу linked_ptr_node --- виртуальный деструктор в данном случае не нужен и только замедляет всё.

Решение зачтено.

Бонусное задание не выполнено.

Тест для бонусного задания (должен компилироваться без предупреждений):

#include "linked_ptr.hpp"

struct C;

int main()
{
    // Should compile. Completeness of C is not needed.
    smart_ptr::linked_ptr<C> p1;
    smart_ptr::linked_ptr<C> p2(p1);

    // Shouldn't compile:
    //smart_ptr::linked_ptr<C> p3(reinterpret_cast<C *>(123));
    //p1.reset(reinterpret_cast<C *>(123));
}

[Vladimir Rutsky]

Milestone ha3-deadline deleted