ha4 lazy strings

[Sergei Shulman]

Здравствуйте,

посмотрите, пожалуйста, реализацию ленивых строк.

С уважением,
Сергей

[cpptester]

Tested revision 699 by shulman.sergej.

Main tests

test	stage	result	info	log
​comp_all_sufficient.cpp	gcc62	FAILURE		​comp_all_sufficient-gcc62.log
​comp_assign.cpp	gcc62	FAILURE		​comp_assign-gcc62.log
​comp_assign_move_type.cpp	gcc62	FAILURE		​comp_assign_move_type-gcc62.log
​comp_assign_move_type_wide.cpp	gcc62	FAILURE		​comp_assign_move_type_wide-gcc62.log
​comp_assign_type.cpp	gcc62	FAILURE		​comp_assign_type-gcc62.log
​comp_assign_type_wide.cpp	gcc62	FAILURE		​comp_assign_type_wide-gcc62.log
​comp_aug_assign_c_str.cpp	gcc62	FAILURE		​comp_aug_assign_c_str-gcc62.log
​comp_aug_assign_c_str_type.cpp	gcc62	FAILURE		​comp_aug_assign_c_str_type-gcc62.log
​comp_aug_assign_c_wstr.cpp	gcc62	FAILURE		​comp_aug_assign_c_wstr-gcc62.log
​comp_aug_assign_c_wstr_type.cpp	gcc62	FAILURE		​comp_aug_assign_c_wstr_type-gcc62.log

Common header used in some tests: ​common.h

[cpptester]

Tested revision 706 by shulman.sergej.

Main tests

test	stage	result	info	log
​comp_char_traits_custom.cpp	gcc62	FAILURE		​comp_char_traits_custom-gcc62.log
​comp_lazy_istring_aug_plus.cpp	gcc62	FAILURE		​comp_lazy_istring_aug_plus-gcc62.log
​run_assign_doesnt_compare.cpp	gcc62	FAILURE		​run_assign_doesnt_compare-gcc62.log
​run_aug_plus_c_str_char_traits_length.cpp	gcc62	FAILURE		​run_aug_plus_c_str_char_traits_length-gcc62.log
​run_aug_plus_c_str_char_traits_no_mem.cpp	gcc62	FAILURE		​run_aug_plus_c_str_char_traits_no_mem-gcc62.log
​run_aug_plus_char_char_traits_no_mem.cpp	gcc62	FAILURE		​run_aug_plus_char_char_traits_no_mem-gcc62.log
​run_aug_plus_lazy_str_char_traits_no_mem.cpp	gcc62	FAILURE		​run_aug_plus_lazy_str_char_traits_no_mem-gcc62.log
​run_char_traits_custom.cpp	gcc62	SUCCESS
	run	SUCCESS
	valgrind	FAILURE	exit code 1	​run_char_traits_custom-valgrind.log
	gcc62-asan	SUCCESS
	asan	FAILURE	exit code 1	​run_char_traits_custom-asan.log
	clang-san	SUCCESS
	san	FAILURE	exit code 1	​run_char_traits_custom-san.log
​run_clear_no_mem.cpp	gcc62	SUCCESS
	run	FAILURE	exit code 139	​run_clear_no_mem-run.log
​run_clear_wide.cpp	gcc62	FAILURE		​run_clear_wide-gcc62.log

Common header used in some tests: ​common.h

[cpptester]

Tested revision 708 by shulman.sergej.

Main tests

test	stage	result	info	log
​run_clear_no_mem.cpp	gcc62	SUCCESS
	run	FAILURE	exit code 139	​run_clear_no_mem-run.log
​run_ctor_no_mem.cpp	gcc62	SUCCESS
	run	FAILURE	exit code 139	​run_ctor_no_mem-run.log
​run_empty.cpp	gcc62	SUCCESS
	run	FAILURE	exit code 139
​run_empty_eq.cpp	gcc62	SUCCESS
	run	FAILURE	exit code 139	​run_empty_eq-run.log
​run_empty_wide.cpp	gcc62	SUCCESS
	run	FAILURE	exit code 139
​run_index_assign_copy_no_mem.cpp	gcc62	SUCCESS
	run	FAILURE	exit code 139	​run_index_assign_copy_no_mem-run.log
​run_swap_with_empty.cpp	gcc62	SUCCESS
	run	FAILURE	exit code 139	​run_swap_with_empty-run.log

Common header used in some tests: ​common.h

[cpptester]

Tested revision 710 by shulman.sergej.

All tests passed. Good job!

[cpptester]

Tested revision 710 by shulman.sergej.

Main tests

test	stage	result	info	log
​run_assign_c_str_no_mem.cpp	gcc62	SUCCESS
	run	FAILURE	exit code 139	​run_assign_c_str_no_mem-run.log

Common header used in some tests: ​common.h

[Vladimir Rutsky]

Замечания:

1. В каких случаях у вас data == nullptr? Мне кажется, что практически никогда, я рекомендую всегда хранить какой-то буфер там и избавиться от большого числа проверок data на nullptr.

Ещё скоро придёт отчет о некоторых новых падающих тестах.

[Vladimir Rutsky]

2. Используйте <cstddef> вместо <stddef.h>.

[cpptester]

Tested revision 710 by shulman.sergej.

Main tests

test	stage	result	info	log
​run_assign_c_str_no_mem.cpp	gcc62	SUCCESS
	run	FAILURE	exit code 139	​run_assign_c_str_no_mem-run.log
​run_char_traits_custom_eq.cpp	gcc62	FAILURE		​run_char_traits_custom_eq-gcc62.log
​run_index_const_wstr.cpp	gcc62	SUCCESS
	run	FAILURE	exit code 139	​run_index_const_wstr-run.log

Common header used in some tests: ​common.h

[cpptester]

Tested revision 912 by shulman.sergej.

All tests passed. Good job!

[Sergei Shulman]

Замечания учёл. Код для прохождения новых тестов доработал, попутно немного сократив.

[Vladimir Rutsky]

Замечания:

1. Вместо собственной реализации подсчета ссылок я бы рекомендовал использовать std::shared_ptr<storage>.

Решение зачтено.

[Vladimir Rutsky]

Milestone ha4-milestone2 deleted