ha6 bind

[Sergei Shulman]

Здравствуйте!

Сделал bind. Посмотрите его, пожалуйста.

[cpptester]

Tested revision 940 by shulman.sergej.

Smoke tests

test	stage	result	info	log
​run_bind_smoke_test.cpp	gcc62	WARNING		​run_bind_smoke_test-gcc62.log
	run	SUCCESS
	valgrind	SUCCESS		​run_bind_smoke_test-valgrind.log
	gcc62-asan	WARNING		​run_bind_smoke_test-gcc62-asan.log
	asan	SUCCESS
	clang-san	FAILURE		​run_bind_smoke_test-clang-san.log

Common header used in some tests: ​common.h

[cpptester]

Tested revision 956 by shulman.sergej.

Smoke tests

test	stage	result	info	log
​run_bind_smoke_test.cpp	gcc62	SUCCESS
	run	SUCCESS
	valgrind	SUCCESS		​run_bind_smoke_test-valgrind.log
	gcc62-asan	SUCCESS
	asan	SUCCESS
	clang-san	FAILURE		​run_bind_smoke_test-clang-san.log

Common header used in some tests: ​common.h

[cpptester]

Tested revision 958 by shulman.sergej.

Smoke tests

test	stage	result	info	log
​run_bind_smoke_test.cpp	gcc62	SUCCESS
	run	SUCCESS
	valgrind	SUCCESS		​run_bind_smoke_test-valgrind.log
	gcc62-asan	SUCCESS
	asan	SUCCESS
	clang-san	WARNING		​run_bind_smoke_test-clang-san.log
	san	SUCCESS

Common header used in some tests: ​common.h

[cpptester]

Tested revision 958 by shulman.sergej.

Main tests

test	stage	result	info	log
​comp_all_sufficient.cpp	gcc62	FAILURE		​comp_all_sufficient-gcc62.log
​comp_include_guard.cpp	gcc62	FAILURE		​comp_include_guard-gcc62.log
​comp_placeholders_linkage.cpp	gcc62	FAILURE		​comp_placeholders_linkage-gcc62.log
​run_lvalue_store.cpp	gcc62	FAILURE		​run_lvalue_store-gcc62.log
​run_lvalue_store2.cpp	gcc62	FAILURE		​run_lvalue_store2-gcc62.log
​run_lvalue_store2_const.cpp	gcc62	FAILURE		​run_lvalue_store2_const-gcc62.log
​run_pass_rvalue.cpp	gcc62	SUCCESS
	run	FAILURE	exit code 139	​run_pass_rvalue-run.log

Common header used in some tests: ​common.h

[cpptester]

Tested revision 965 by shulman.sergej.

Main tests

test	stage	result	info	log
​run_pass_rvalue.cpp	gcc62	SUCCESS
	run	FAILURE	exit code 139	​run_pass_rvalue-run.log

Common header used in some tests: ​common.h

[cpptester]

Tested revision 979 by shulman.sergej.

Main tests

test	stage	result	info	log
​run_lvalue_store.cpp	gcc62	FAILURE		​run_lvalue_store-gcc62.log
​run_lvalue_store2.cpp	gcc62	FAILURE		​run_lvalue_store2-gcc62.log
​run_lvalue_store2_const.cpp	gcc62	FAILURE		​run_lvalue_store2_const-gcc62.log

Common header used in some tests: ​common.h

[cpptester]

Tested revision 984 by shulman.sergej.

Smoke tests

test	stage	result	info	log
​run_bind_smoke_test.cpp	gcc62	SUCCESS
	run	SUCCESS
	valgrind	SUCCESS		​run_bind_smoke_test-valgrind.log
	gcc62-asan	SUCCESS
	asan	FAILURE	exit code 1	​run_bind_smoke_test-asan.log
	clang-san	SUCCESS
	san	SUCCESS

Common header used in some tests: ​common.h

[Vladimir Rutsky]

Сейчас поправлю ASAN...

[cpptester]

Tested revision 984 by shulman.sergej.

All tests passed. Good job!

[Sergei Shulman]

Спасибо!

Теперь жду комментарии про код (или новые тесты)

[cpptester]

Tested revision 997 by shulman.sergej.

All tests passed. Good job!

[Vladimir Rutsky]

Замечания:

1. Объявляя таким образом placeholder-ы, вы нарушаете ODR при использовании bind.hpp в нескольких единицах трансляции:

	details::Placeholder<1> _1;
	details::Placeholder<2> _2;

Попробуйте скомпилировать один выполняемый файл, слинкованный из двух cpp:

// part1.cpp
#include "bind.hpp"

int main()
{
}

// part2.cpp
#include "bind.hpp"

$ g++ -Wall -std=c++14 part1.cpp part2.cpp 
/tmp/ccER0vc3.o:(.bss+0x0): multiple definition of `fn::_1'
/tmp/ccx7gY3L.o:(.bss+0x0): first defined here
/tmp/ccER0vc3.o:(.bss+0x1): multiple definition of `fn::_2'
/tmp/ccx7gY3L.o:(.bss+0x1): first defined here
collect2: error: ld returned 1 exit status

Исправьте, пожалуйста, в ближайшее время.

[cpptester]

Tested revision 1041 by shulman.sergej.

All tests passed. Good job!

[cpptester]

Tested revision 1043 by shulman.sergej.

All tests passed. Good job!

[Sergei Shulman]

Исправил, ограничив область видимости, теперь компилируется.
Надеюсь, больше ошибок нет.

[Vladimir Rutsky]

Решение зачтено.

[Vladimir Rutsky]

Milestone ha6-deadline deleted