#162 closed ожидается проверка (задача сдана)
ha6 bind
Reported by: | Sergei Shulman | Owned by: | Vladimir Rutsky |
---|---|---|---|
Priority: | проверка | Milestone: | |
Component: | HA#6 bind | Version: | 1.0 |
Keywords: | Cc: |
Description
Здравствуйте!
Сделал bind. Посмотрите его, пожалуйста.
Change History (17)
comment:1 Changed 7 years ago by
Type: | ожидается проверка → ожидаются исправления |
---|
comment:2 Changed 7 years ago by
Tested revision 956 by shulman.sergej.
Smoke tests
test | stage | result | info | log |
---|---|---|---|---|
gcc62 | SUCCESS | |||
run | SUCCESS | |||
valgrind | SUCCESS | |||
gcc62-asan | SUCCESS | |||
asan | SUCCESS | |||
clang-san | FAILURE | |||
Common header used in some tests: common.h
comment:3 Changed 7 years ago by
Tested revision 958 by shulman.sergej.
Smoke tests
test | stage | result | info | log |
---|---|---|---|---|
gcc62 | SUCCESS | |||
run | SUCCESS | |||
valgrind | SUCCESS | |||
gcc62-asan | SUCCESS | |||
asan | SUCCESS | |||
clang-san | WARNING | |||
san | SUCCESS | |||
Common header used in some tests: common.h
comment:4 Changed 7 years ago by
Tested revision 958 by shulman.sergej.
Main tests
test | stage | result | info | log |
---|---|---|---|---|
gcc62 | FAILURE | |||
gcc62 | FAILURE | |||
gcc62 | FAILURE | |||
gcc62 | FAILURE | |||
gcc62 | FAILURE | |||
gcc62 | FAILURE | |||
gcc62 | SUCCESS | |||
run | FAILURE | exit code 139 | ||
Common header used in some tests: common.h
comment:5 Changed 7 years ago by
Tested revision 965 by shulman.sergej.
Main tests
test | stage | result | info | log |
---|---|---|---|---|
gcc62 | SUCCESS | |||
run | FAILURE | exit code 139 | ||
Common header used in some tests: common.h
comment:6 Changed 7 years ago by
Tested revision 979 by shulman.sergej.
Main tests
test | stage | result | info | log |
---|---|---|---|---|
gcc62 | FAILURE | |||
gcc62 | FAILURE | |||
gcc62 | FAILURE | |||
Common header used in some tests: common.h
comment:7 Changed 7 years ago by
Tested revision 984 by shulman.sergej.
Smoke tests
test | stage | result | info | log |
---|---|---|---|---|
gcc62 | SUCCESS | |||
run | SUCCESS | |||
valgrind | SUCCESS | |||
gcc62-asan | SUCCESS | |||
asan | FAILURE | exit code 1 | ||
clang-san | SUCCESS | |||
san | SUCCESS | |||
Common header used in some tests: common.h
comment:10 Changed 7 years ago by
Type: | ожидаются исправления → ожидается проверка |
---|
Спасибо!
Теперь жду комментарии про код (или новые тесты)
comment:11 Changed 7 years ago by
Tested revision 997 by shulman.sergej.
All tests passed. Good job!
comment:12 Changed 7 years ago by
Milestone: | ha6-milestone2 → ha6-deadline |
---|---|
Type: | ожидается проверка → ожидаются исправления |
Замечания:
- Объявляя таким образом placeholder-ы, вы нарушаете ODR при использовании
bind.hpp
в нескольких единицах трансляции:
details::Placeholder<1> _1; details::Placeholder<2> _2;
Попробуйте скомпилировать один выполняемый файл, слинкованный из двух cpp:
// part1.cpp #include "bind.hpp" int main() { }
// part2.cpp #include "bind.hpp"
$ g++ -Wall -std=c++14 part1.cpp part2.cpp /tmp/ccER0vc3.o:(.bss+0x0): multiple definition of `fn::_1' /tmp/ccx7gY3L.o:(.bss+0x0): first defined here /tmp/ccER0vc3.o:(.bss+0x1): multiple definition of `fn::_2' /tmp/ccx7gY3L.o:(.bss+0x1): first defined here collect2: error: ld returned 1 exit status
comment:13 Changed 7 years ago by
Tested revision 1041 by shulman.sergej.
All tests passed. Good job!
comment:14 Changed 7 years ago by
Tested revision 1043 by shulman.sergej.
All tests passed. Good job!
comment:15 Changed 7 years ago by
Type: | ожидаются исправления → ожидается проверка |
---|
Исправил, ограничив область видимости, теперь компилируется.
Надеюсь, больше ошибок нет.
Tested revision 940 by shulman.sergej.
Smoke tests
test
stage
result
info
log
run_bind_smoke_test.cpp
gcc62
run_bind_smoke_test-gcc62.log
run
valgrind
run_bind_smoke_test-valgrind.log
gcc62-asan
run_bind_smoke_test-gcc62-asan.log
asan
clang-san
run_bind_smoke_test-clang-san.log
Common header used in some tests: common.h