Opened 6 years ago

Closed 6 years ago

#263 closed ожидается проверка (задача сдана)

HA3 Petryakov Ivan

Reported by: Иван Owned by: rutsky,grabovoy.philipp
Priority: проверка Milestone: ha3-deadline
Component: HA#3 linked_ptr Version:
Keywords: Cc:

Description


Change History (31)

comment:1 Changed 6 years ago by cpptester

Type: ожидается проверкаожидаются исправления

Tested revision 387 by petryakov.ivan.

Smoke tests

test

stage

result

info

log

run_linked_ptr_gen_smoke_test.cpp

WARNING

run_linked_ptr_gen_smoke_test-gcc62.log

SUCCESS
SUCCESS

run_linked_ptr_gen_smoke_test-valgrind.log

WARNING

run_linked_ptr_gen_smoke_test-gcc62-asan.log

SUCCESS
SUCCESS
SUCCESS

run_smoke_test.cpp

FAILURE

run_smoke_test-gcc62.log

Common header used in some tests: common.h

comment:2 Changed 6 years ago by cpptester

Tested revision 388 by petryakov.ivan.

Smoke tests

test

stage

result

info

log

run_linked_ptr_gen_smoke_test.cpp

WARNING

run_linked_ptr_gen_smoke_test-gcc62.log

SUCCESS
SUCCESS

run_linked_ptr_gen_smoke_test-valgrind.log

WARNING

run_linked_ptr_gen_smoke_test-gcc62-asan.log

SUCCESS
SUCCESS
SUCCESS

run_smoke_test.cpp

WARNING

run_smoke_test-gcc62.log

SUCCESS
SUCCESS

run_smoke_test-valgrind.log

WARNING

run_smoke_test-gcc62-asan.log

SUCCESS
SUCCESS
SUCCESS

Common header used in some tests: common.h

comment:7 Changed 6 years ago by cpptester

Tested revision 405 by petryakov.ivan.

Smoke tests

test

stage

result

info

log

run_linked_ptr_gen_smoke_test.cpp

FAILURE

run_linked_ptr_gen_smoke_test-gcc62.log

run_smoke_test.cpp

FAILURE

run_smoke_test-gcc62.log

Common header used in some tests: common.h

comment:8 Changed 6 years ago by cpptester

Tested revision 406 by petryakov.ivan.

Smoke tests

test

stage

result

info

log

run_smoke_test.cpp

SUCCESS
SUCCESS
FAILURE

exit code 1

run_smoke_test-valgrind.log

SUCCESS
FAILURE

exit code 1

run_smoke_test-asan.log

SUCCESS
FAILURE

exit code 1

run_smoke_test-san.log

Common header used in some tests: common.h

comment:9 Changed 6 years ago by cpptester

Tested revision 407 by petryakov.ivan.

Smoke tests

test

stage

result

info

log

run_smoke_test.cpp

SUCCESS
SUCCESS
FAILURE

exit code 1

run_smoke_test-valgrind.log

SUCCESS
FAILURE

exit code 1

run_smoke_test-asan.log

SUCCESS
FAILURE

exit code 1

run_smoke_test-san.log

Common header used in some tests: common.h

comment:10 Changed 6 years ago by cpptester

Tested revision 408 by petryakov.ivan.

Smoke tests

test

stage

result

info

log

run_smoke_test.cpp

SUCCESS
SUCCESS
FAILURE

exit code 1

run_smoke_test-valgrind.log

SUCCESS
FAILURE

exit code 1

run_smoke_test-asan.log

SUCCESS
FAILURE

exit code 1

run_smoke_test-san.log

Common header used in some tests: common.h

comment:11 Changed 6 years ago by cpptester

Tested revision 409 by petryakov.ivan.

Smoke tests

test

stage

result

info

log

run_smoke_test.cpp

SUCCESS
SUCCESS
FAILURE

exit code 1

run_smoke_test-valgrind.log

SUCCESS
FAILURE

exit code 1

run_smoke_test-asan.log

SUCCESS
FAILURE

exit code 1

run_smoke_test-san.log

Common header used in some tests: common.h

comment:12 Changed 6 years ago by cpptester

Tested revision 410 by petryakov.ivan.

Smoke tests

test

stage

result

info

log

run_smoke_test.cpp

SUCCESS
SUCCESS
FAILURE

exit code 1

run_smoke_test-valgrind.log

SUCCESS
FAILURE

exit code 1

run_smoke_test-asan.log

SUCCESS
FAILURE

exit code 1

run_smoke_test-san.log

Common header used in some tests: common.h

comment:13 Changed 6 years ago by cpptester

Tested revision 411 by petryakov.ivan.

Smoke tests

test

stage

result

info

log

run_smoke_test.cpp

SUCCESS
SUCCESS
FAILURE

exit code 1

run_smoke_test-valgrind.log

SUCCESS
FAILURE

exit code 1

run_smoke_test-asan.log

SUCCESS
FAILURE

exit code 1

run_smoke_test-san.log

Common header used in some tests: common.h

comment:15 Changed 6 years ago by cpptester

Tested revision 413 by petryakov.ivan.

Main tests

test

stage

result

info

log

ncomp_assign_derived.cpp

FAILURE

ncomp_copy_ctor_from_base1.cpp

FAILURE

ncomp_copy_ctor_from_base1_polymorphic.cpp

FAILURE

ncomp_copy_ctor_from_base2.cpp

FAILURE

ncomp_copy_ctor_from_base2_polymorphic.cpp

FAILURE

ncomp_ctor_from_base.cpp

FAILURE

Common header used in some tests: common.h

comment:16 Changed 6 years ago by cpptester

Tested revision 414 by petryakov.ivan.

All tests passed. Good job!

comment:17 Changed 6 years ago by Vladimir Rutsky

Type: ожидаются исправленияожидается проверка

comment:18 Changed 6 years ago by Vladimir Rutsky

Type: ожидается проверкаожидаются исправления

Замечания:

  1. Не используйте виртуальные методы. В данном случае базовый класс это приватная деталь реализации, и никто не должен хранить linked_ptr по указателю на базовый класс, и виртуальный деструктор здесь не нужен.
  1. Конструирование от типа U * и linked_ptr<U> должно быть допустимо только при неявном приведении U * к T *. Вы явно проверяете, что U это базовый класс T и делаете static_cast. Замените эти явные проверки простым присвоением U * к T * --- это будет компилироваться тогда и только тогда, когда есть неявное приведение U * к T *.
  1. Работа со списком некорректна. Я добавил тест, на котором ваше решение падает.

Я не могу зачесть решение с такими ошибками. Исправьте, пожалуйста, в ближайшее время.

comment:19 Changed 6 years ago by cpptester

Tested revision 414 by petryakov.ivan.

Main tests

test

stage

result

info

log

run_gen_024_08x11_1161x4861_12069x74612_0x4_4x5_0_73D87982.cpp

FAILURE

run_gen_024_08x11_1161x4861_12069x74612_0x4_4x5_0_73D87982-gcc62.log

Common header used in some tests: common.h

comment:20 Changed 6 years ago by cpptester

comment:21 Changed 6 years ago by cpptester

Tested revision 521 by petryakov.ivan.

Smoke tests

test

stage

result

info

log

run_linked_ptr_gen_smoke_test.cpp

SUCCESS
FAILURE

exit code 137

run_linked_ptr_gen_smoke_test-run.log

run_smoke_test.cpp

SUCCESS
SUCCESS
FAILURE

exit code 1

run_smoke_test-valgrind.log

SUCCESS
FAILURE

exit code 1

run_smoke_test-asan.log

SUCCESS
FAILURE

exit code 1

run_smoke_test-san.log

Common header used in some tests: common.h

comment:23 Changed 6 years ago by cpptester

comment:24 Changed 6 years ago by cpptester

comment:25 Changed 6 years ago by cpptester

Tested revision 525 by petryakov.ivan.

Smoke tests

test

stage

result

info

log

run_smoke_test.cpp

SUCCESS
SUCCESS
FAILURE

exit code 1

run_smoke_test-valgrind.log

SUCCESS
FAILURE

exit code 1

run_smoke_test-asan.log

SUCCESS
FAILURE

exit code 1

run_smoke_test-san.log

Common header used in some tests: common.h

comment:28 Changed 6 years ago by cpptester

Tested revision 529 by petryakov.ivan.

Main tests

test

stage

result

info

log

run_gen_042_14x20_0583233x9694844_4478742457x5586_8917DE98.cpp

SUCCESS
FAILURE

exit code 139

run_gen_042_14x20_0583233x9694844_4478742457x5586_8917DE98-run.log

Common header used in some tests: common.h

comment:29 Changed 6 years ago by cpptester

Tested revision 539 by petryakov.ivan.

All tests passed. Good job!

comment:30 Changed 6 years ago by Иван

Type: ожидаются исправленияожидается проверка

Кажется, я нашел свою ошибку. Проверьте, пожалуйста!

comment:31 Changed 6 years ago by Vladimir Rutsky

Resolution: задача сдана
Status: newclosed

Решение зачтено. Бонусное задание не выполнено.

Note: See TracTickets for help on using tickets.