Opened 6 years ago
Closed 6 years ago
#263 closed ожидается проверка (задача сдана)
HA3 Petryakov Ivan
Reported by: | Иван | Owned by: | rutsky,grabovoy.philipp |
---|---|---|---|
Priority: | проверка | Milestone: | ha3-deadline |
Component: | HA#3 linked_ptr | Version: | |
Keywords: | Cc: |
Description
Change History (31)
comment:1 Changed 6 years ago by
Type: | ожидается проверка → ожидаются исправления |
---|
comment:2 Changed 6 years ago by
Tested revision 388 by petryakov.ivan.
Smoke tests
test | stage | result | info | log |
---|---|---|---|---|
WARNING | ||||
SUCCESS | ||||
SUCCESS | ||||
WARNING | ||||
SUCCESS | ||||
SUCCESS | ||||
SUCCESS | ||||
WARNING | ||||
SUCCESS | ||||
SUCCESS | ||||
WARNING | ||||
SUCCESS | ||||
SUCCESS | ||||
SUCCESS | ||||
Common header used in some tests: common.h
comment:3 Changed 6 years ago by
Tested revision 389 by petryakov.ivan.
Main tests
test | stage | result | info | log |
---|---|---|---|---|
FAILURE | ||||
FAILURE | ||||
FAILURE | ||||
FAILURE | ||||
FAILURE | ||||
FAILURE | ||||
FAILURE | ||||
FAILURE | ||||
FAILURE | ||||
FAILURE | ||||
Common header used in some tests: common.h
comment:4 Changed 6 years ago by
Tested revision 402 by petryakov.ivan.
Main tests
test | stage | result | info | log |
---|---|---|---|---|
FAILURE | ||||
FAILURE | ||||
FAILURE | ||||
FAILURE | ||||
FAILURE | ||||
FAILURE | ||||
FAILURE | ||||
FAILURE | ||||
FAILURE | ||||
FAILURE | ||||
Common header used in some tests: common.h
comment:5 Changed 6 years ago by
Tested revision 403 by petryakov.ivan.
Main tests
test | stage | result | info | log |
---|---|---|---|---|
FAILURE | ||||
FAILURE | ||||
FAILURE | ||||
FAILURE | ||||
FAILURE | ||||
FAILURE | ||||
FAILURE | ||||
FAILURE | ||||
FAILURE | ||||
FAILURE | ||||
Common header used in some tests: common.h
comment:6 Changed 6 years ago by
Tested revision 404 by petryakov.ivan.
Main tests
test | stage | result | info | log |
---|---|---|---|---|
FAILURE | ||||
FAILURE | ||||
FAILURE | ||||
FAILURE | ||||
FAILURE | ||||
FAILURE | ||||
run_gen_011_1x4_0x1_34x35_3x4_4x5_03x13_00x13_12x_1880070F.cpp | SUCCESS | |||
FAILURE | exit code 139 | run_gen_011_1x4_0x1_34x35_3x4_4x5_03x13_00x13_12x_1880070F-run.log | ||
run_gen_055_15x26_28180541x35357669_1448194617849_DF45FC8F.cpp | SUCCESS | |||
FAILURE | exit code 139 | run_gen_055_15x26_28180541x35357669_1448194617849_DF45FC8F-run.log | ||
SUCCESS | ||||
SUCCESS | ||||
FAILURE | exit code 1 | |||
SUCCESS | ||||
FAILURE | exit code 1 | |||
SUCCESS | ||||
FAILURE | exit code 1 | |||
Common header used in some tests: common.h
comment:7 Changed 6 years ago by
Tested revision 405 by petryakov.ivan.
Smoke tests
test | stage | result | info | log |
---|---|---|---|---|
FAILURE | ||||
FAILURE | ||||
Common header used in some tests: common.h
comment:8 Changed 6 years ago by
Tested revision 406 by petryakov.ivan.
Smoke tests
test | stage | result | info | log |
---|---|---|---|---|
SUCCESS | ||||
SUCCESS | ||||
FAILURE | exit code 1 | |||
SUCCESS | ||||
FAILURE | exit code 1 | |||
SUCCESS | ||||
FAILURE | exit code 1 | |||
Common header used in some tests: common.h
comment:9 Changed 6 years ago by
Tested revision 407 by petryakov.ivan.
Smoke tests
test | stage | result | info | log |
---|---|---|---|---|
SUCCESS | ||||
SUCCESS | ||||
FAILURE | exit code 1 | |||
SUCCESS | ||||
FAILURE | exit code 1 | |||
SUCCESS | ||||
FAILURE | exit code 1 | |||
Common header used in some tests: common.h
comment:10 Changed 6 years ago by
Tested revision 408 by petryakov.ivan.
Smoke tests
test | stage | result | info | log |
---|---|---|---|---|
SUCCESS | ||||
SUCCESS | ||||
FAILURE | exit code 1 | |||
SUCCESS | ||||
FAILURE | exit code 1 | |||
SUCCESS | ||||
FAILURE | exit code 1 | |||
Common header used in some tests: common.h
comment:11 Changed 6 years ago by
Tested revision 409 by petryakov.ivan.
Smoke tests
test | stage | result | info | log |
---|---|---|---|---|
SUCCESS | ||||
SUCCESS | ||||
FAILURE | exit code 1 | |||
SUCCESS | ||||
FAILURE | exit code 1 | |||
SUCCESS | ||||
FAILURE | exit code 1 | |||
Common header used in some tests: common.h
comment:12 Changed 6 years ago by
Tested revision 410 by petryakov.ivan.
Smoke tests
test | stage | result | info | log |
---|---|---|---|---|
SUCCESS | ||||
SUCCESS | ||||
FAILURE | exit code 1 | |||
SUCCESS | ||||
FAILURE | exit code 1 | |||
SUCCESS | ||||
FAILURE | exit code 1 | |||
Common header used in some tests: common.h
comment:13 Changed 6 years ago by
Tested revision 411 by petryakov.ivan.
Smoke tests
test | stage | result | info | log |
---|---|---|---|---|
SUCCESS | ||||
SUCCESS | ||||
FAILURE | exit code 1 | |||
SUCCESS | ||||
FAILURE | exit code 1 | |||
SUCCESS | ||||
FAILURE | exit code 1 | |||
Common header used in some tests: common.h
comment:14 Changed 6 years ago by
Tested revision 412 by petryakov.ivan.
Main tests
test | stage | result | info | log |
---|---|---|---|---|
FAILURE | ||||
FAILURE | ||||
FAILURE | ||||
FAILURE | ||||
FAILURE | ||||
FAILURE | ||||
FAILURE | ||||
FAILURE | ||||
run_gen_015_5x6_062x131_193x285_1x4_1x6_1x6_3x3_0_D034969E.cpp | FAILURE | run_gen_015_5x6_062x131_193x285_1x4_1x6_1x6_3x3_0_D034969E-gcc62.log | ||
run_gen_021_8x9_4113x4861_397x815_4x4_3x4_5x5_4x4_C4F2B4F7.cpp | FAILURE | run_gen_021_8x9_4113x4861_397x815_4x4_3x4_5x5_4x4_C4F2B4F7-gcc62.log | ||
Common header used in some tests: common.h
comment:15 Changed 6 years ago by
Tested revision 413 by petryakov.ivan.
Main tests
test | stage | result | info | log |
---|---|---|---|---|
FAILURE | ||||
FAILURE | ||||
FAILURE | ||||
FAILURE | ||||
FAILURE | ||||
FAILURE | ||||
Common header used in some tests: common.h
comment:16 Changed 6 years ago by
Tested revision 414 by petryakov.ivan.
All tests passed. Good job!
comment:17 Changed 6 years ago by
Type: | ожидаются исправления → ожидается проверка |
---|
comment:18 Changed 6 years ago by
Type: | ожидается проверка → ожидаются исправления |
---|
Замечания:
- Не используйте виртуальные методы. В данном случае базовый класс это приватная деталь реализации, и никто не должен хранить
linked_ptr
по указателю на базовый класс, и виртуальный деструктор здесь не нужен.
- Конструирование от типа
U *
иlinked_ptr<U>
должно быть допустимо только при неявном приведенииU *
кT *
. Вы явно проверяете, чтоU
это базовый классT
и делаетеstatic_cast
. Замените эти явные проверки простым присвоениемU *
кT *
--- это будет компилироваться тогда и только тогда, когда есть неявное приведениеU *
кT *
.
- Работа со списком некорректна. Я добавил тест, на котором ваше решение падает.
Я не могу зачесть решение с такими ошибками. Исправьте, пожалуйста, в ближайшее время.
comment:19 Changed 6 years ago by
Tested revision 414 by petryakov.ivan.
Main tests
test | stage | result | info | log |
---|---|---|---|---|
run_gen_024_08x11_1161x4861_12069x74612_0x4_4x5_0_73D87982.cpp | FAILURE | run_gen_024_08x11_1161x4861_12069x74612_0x4_4x5_0_73D87982-gcc62.log | ||
Common header used in some tests: common.h
comment:20 Changed 6 years ago by
Tested revision 414 by petryakov.ivan.
Main tests
test | stage | result | info | log |
---|---|---|---|---|
run_gen_024_08x11_1161x4861_12069x74612_0x4_4x5_0_73D87982.cpp | SUCCESS | |||
FAILURE | exit code 139 | run_gen_024_08x11_1161x4861_12069x74612_0x4_4x5_0_73D87982-run.log | ||
run_gen_042_14x20_0583233x9694844_4478742457x5586_8917DE98.cpp | SUCCESS | |||
FAILURE | exit code 139 | run_gen_042_14x20_0583233x9694844_4478742457x5586_8917DE98-run.log | ||
Common header used in some tests: common.h
comment:21 Changed 6 years ago by
Tested revision 521 by petryakov.ivan.
Smoke tests
test | stage | result | info | log |
---|---|---|---|---|
SUCCESS | ||||
FAILURE | exit code 137 | |||
SUCCESS | ||||
SUCCESS | ||||
FAILURE | exit code 1 | |||
SUCCESS | ||||
FAILURE | exit code 1 | |||
SUCCESS | ||||
FAILURE | exit code 1 | |||
Common header used in some tests: common.h
comment:22 Changed 6 years ago by
Tested revision 522 by petryakov.ivan.
Main tests
test | stage | result | info | log |
---|---|---|---|---|
run_gen_015_5x6_062x131_193x285_1x4_1x6_1x6_3x3_0_D034969E.cpp | SUCCESS | |||
FAILURE | exit code 139 | run_gen_015_5x6_062x131_193x285_1x4_1x6_1x6_3x3_0_D034969E-run.log | ||
run_gen_024_08x11_1161x4861_12069x74612_0x4_4x5_0_73D87982.cpp | SUCCESS | |||
FAILURE | exit code 139 | run_gen_024_08x11_1161x4861_12069x74612_0x4_4x5_0_73D87982-run.log | ||
run_gen_042_14x20_0583233x9694844_4478742457x5586_8917DE98.cpp | SUCCESS | |||
FAILURE | exit code 139 | run_gen_042_14x20_0583233x9694844_4478742457x5586_8917DE98-run.log | ||
Common header used in some tests: common.h
comment:23 Changed 6 years ago by
Tested revision 523 by petryakov.ivan.
Main tests
test | stage | result | info | log |
---|---|---|---|---|
run_gen_024_08x11_1161x4861_12069x74612_0x4_4x5_0_73D87982.cpp | SUCCESS | |||
FAILURE | exit code 139 | run_gen_024_08x11_1161x4861_12069x74612_0x4_4x5_0_73D87982-run.log | ||
run_gen_042_14x20_0583233x9694844_4478742457x5586_8917DE98.cpp | SUCCESS | |||
FAILURE | exit code 139 | run_gen_042_14x20_0583233x9694844_4478742457x5586_8917DE98-run.log | ||
Common header used in some tests: common.h
comment:24 Changed 6 years ago by
Tested revision 524 by petryakov.ivan.
Main tests
test | stage | result | info | log |
---|---|---|---|---|
run_gen_024_08x11_1161x4861_12069x74612_0x4_4x5_0_73D87982.cpp | SUCCESS | |||
FAILURE | exit code 139 | run_gen_024_08x11_1161x4861_12069x74612_0x4_4x5_0_73D87982-run.log | ||
run_gen_042_14x20_0583233x9694844_4478742457x5586_8917DE98.cpp | SUCCESS | |||
FAILURE | exit code 139 | run_gen_042_14x20_0583233x9694844_4478742457x5586_8917DE98-run.log | ||
Common header used in some tests: common.h
comment:25 Changed 6 years ago by
Tested revision 525 by petryakov.ivan.
Smoke tests
test | stage | result | info | log |
---|---|---|---|---|
SUCCESS | ||||
SUCCESS | ||||
FAILURE | exit code 1 | |||
SUCCESS | ||||
FAILURE | exit code 1 | |||
SUCCESS | ||||
FAILURE | exit code 1 | |||
Common header used in some tests: common.h
comment:26 Changed 6 years ago by
Tested revision 526 by petryakov.ivan.
Main tests
Common header used in some tests: common.h
comment:27 Changed 6 years ago by
Tested revision 528 by petryakov.ivan.
Main tests
Common header used in some tests: common.h
comment:28 Changed 6 years ago by
Tested revision 529 by petryakov.ivan.
Main tests
test | stage | result | info | log |
---|---|---|---|---|
run_gen_042_14x20_0583233x9694844_4478742457x5586_8917DE98.cpp | SUCCESS | |||
FAILURE | exit code 139 | run_gen_042_14x20_0583233x9694844_4478742457x5586_8917DE98-run.log | ||
Common header used in some tests: common.h
comment:29 Changed 6 years ago by
Tested revision 539 by petryakov.ivan.
All tests passed. Good job!
comment:30 Changed 6 years ago by
Type: | ожидаются исправления → ожидается проверка |
---|
Кажется, я нашел свою ошибку. Проверьте, пожалуйста!
comment:31 Changed 6 years ago by
Resolution: | → задача сдана |
---|---|
Status: | new → closed |
Решение зачтено. Бонусное задание не выполнено.
Tested revision 387 by petryakov.ivan.
Smoke tests
test
stage
result
info
log
run_linked_ptr_gen_smoke_test.cpp
run_linked_ptr_gen_smoke_test-gcc62.log
run_linked_ptr_gen_smoke_test-valgrind.log
run_linked_ptr_gen_smoke_test-gcc62-asan.log
run_smoke_test.cpp
run_smoke_test-gcc62.log
Common header used in some tests: common.h